Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/664
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/664#issuecomment-128833636
LGTM, i will have a go at merging when I have Miguels new version of the
merge script and the origin/apache triangle ready on my new (post schuberg
philis) work
Github user kevindierkx commented on the pull request:
https://github.com/apache/cloudstack/pull/664#issuecomment-128695172
I've removed the above mentions of commented code. Should be all set.
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/664#discussion_r36516193
--- Diff: ui/scripts/ui-custom/accountsWizard.js ---
@@ -130,89 +130,89 @@
dataType: "json",
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/664#discussion_r36516165
--- Diff: ui/scripts/templates.js ---
@@ -2746,7 +2722,7 @@
if (((isAdmin() == false && !(jsonObj.domainid == g_domainid &&
jsonObj.account
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/664#discussion_r36515654
--- Diff: ui/scripts/zoneWizard.js ---
@@ -4363,12 +4363,12 @@
array1.push("&password=" +
todb(args.data.cluster.vCenter
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/664#discussion_r36515683
--- Diff: ui/scripts/zoneWizard.js ---
@@ -4377,23 +4377,23 @@
if (args.data.cluster.vSwitchGuestType != "")
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/664#discussion_r36515666
--- Diff: ui/scripts/zoneWizard.js ---
@@ -4363,12 +4363,12 @@
array1.push("&password=" +
todb(args.data.cluster.vCenter
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/664#discussion_r36515568
--- Diff: ui/scripts/zoneWizard.js ---
@@ -2108,17 +2108,17 @@
$fields.filter('[rel=username]').hide
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/664#discussion_r36515531
--- Diff: ui/scripts/zoneWizard.js ---
@@ -1972,45 +1972,45 @@
}
},
secondaryStorage: {
-
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/664#discussion_r36515479
--- Diff: ui/scripts/zoneWizard.js ---
@@ -1139,15 +1139,15 @@
dependsOn: 'overridepublictraffic'
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/664#discussion_r36515504
--- Diff: ui/scripts/zoneWizard.js ---
@@ -1221,14 +1221,14 @@
},
*/
-
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/664#discussion_r36515461
--- Diff: ui/scripts/zoneWizard.js ---
@@ -1139,15 +1139,15 @@
dependsOn: 'overridepublictraffic'
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/664#discussion_r36515489
--- Diff: ui/scripts/zoneWizard.js ---
@@ -1221,14 +1221,14 @@
},
*/
--- End diff --
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/664#discussion_r36515422
--- Diff: ui/scripts/zoneWizard.js ---
@@ -983,12 +983,12 @@
} else {
-
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/664#discussion_r36514941
--- Diff: ui/scripts/zoneWizard.js ---
@@ -963,16 +963,16 @@
if ($(this).val() == "VMware") {
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/664#discussion_r36514806
--- Diff: ui/scripts/vpc.js ---
@@ -155,41 +155,41 @@
};
*/
//virtualmachineids param
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/664#discussion_r36514699
--- Diff: ui/scripts/ui/widgets/listView.js ---
@@ -275,7 +275,7 @@
});
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/664#discussion_r36514600
--- Diff: ui/scripts/ui/widgets/detailView.js ---
@@ -1062,19 +1062,19 @@
//???
/*
-
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/664#discussion_r36514540
--- Diff: ui/scripts/ui-custom/regions.js ---
@@ -37,9 +37,9 @@
$li.data('region-data', region);
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/664#discussion_r36514359
--- Diff: ui/scripts/templates.js ---
@@ -2735,8 +2735,8 @@
/*
if(g_regionsecondaryenabled != true) {
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/664#discussion_r36514301
--- Diff: ui/scripts/templates.js ---
@@ -2689,14 +2689,14 @@
//do nothing
} else {
allowedActions.push
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/664#discussion_r36514016
--- Diff: ui/scripts/templates.js ---
@@ -519,16 +519,16 @@
});
}
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/664#issuecomment-128689329
We've used the following scripts to remove the trailing white spaces and
leading tabs:
Tabs to 4 white spaces:
find . -iname '*.js' -type f -exec
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/664#discussion_r36513912
--- Diff: ui/scripts/storage.js ---
@@ -55,13 +55,13 @@
}
/*
-
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/664#discussion_r36513758
--- Diff: ui/scripts/regions.js ---
@@ -197,7 +197,7 @@
var region = args.context.regions[0];
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/664#discussion_r36513703
--- Diff: ui/scripts/instances.js ---
@@ -1959,16 +1959,16 @@
},
converter:
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/664#issuecomment-128685238
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/664#issuecomment-128682659
@karuturi @DaanHoogland @remibergsma As discussed on Slack August 3rd.
---
If your project is set up for it, you can reply to this email and have your
reply appe
GitHub user kevindierkx opened a pull request:
https://github.com/apache/cloudstack/pull/664
Removed leading tabs and trailing spaces from ui/scripts/*.js
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kevindierkx/cloudstack mas
30 matches
Mail list logo
