Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1102#issuecomment-159047122
@DaanHoogland,
@cristofolini did not run a mvn build witth "-Dnoredist". Sadly, we did not
realize that there were some projects that were not built w
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1102#issuecomment-158987752
@cristofolini github doesn't show JuniperSRXExternalFirewallElement. It
has a syntax error. Did you compile this? and did you use -Dnoredist? that part
would
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1102
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1102#issuecomment-158896493
LGTM, checked the code. It felt like skimming at times as 607 lines were
removed ;) I don't think there is any problem though.
---
If your project is set up f
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1102#issuecomment-158896104
LGTM, based on a set of tests that I run on this branch. Screenshot is from
an experimental Jenkins job (that runs the same tests I did manually until now).
GitHub user cristofolini opened a pull request:
https://github.com/apache/cloudstack/pull/1102
Removed unnecessary @Local annotations and their respective imports
Following @rafaelweingartner 's findings in PR #714 that many spring beans
contained an @Local annotation, we've decided
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/853
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/853#issuecomment-141811824
@rafaelweingartner Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/853#issuecomment-141803331
@cristofolini, could you squash your commits into a single one?
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/853#issuecomment-141711752
Hi @critofolini, I think that there is a problem in your PR in class:
SecurityGroupManagerImpl
---
If your project is set up for it, you can reply to this
GitHub user cristofolini opened a pull request:
https://github.com/apache/cloudstack/pull/853
Removed unnecessary @Local annotations and their respective imports
Following @rafaelweingartner 's findings in PR #714 that many spring beans
contained an @Local annotation, we've decided
11 matches
Mail list logo
