[GitHub] cloudstack pull request: Removed unused agent command AttachVolume...

2015-08-27 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/743#issuecomment-135448301 @koushik-das I tried it and it works for me. Can you tell me about your environment (OS, shell, ?) Maybe I might be able to figure it out (line 220 maybe). You c

[GitHub] cloudstack pull request: Removed unused agent command AttachVolume...

2015-08-27 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/743#issuecomment-135400836 Output of the tmp file $cat .git-tmp-message.txt Merge pull request #743 from koushik-das/code_cleanup Removed unused agent command AttachVol

[GitHub] cloudstack pull request: Removed unused agent command AttachVolume...

2015-08-27 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/743#issuecomment-135398381 @remibergsma I merged this using the tool but still the merge commit didn't automatically get the messages. I manually added some of the messages for now. For an

[GitHub] cloudstack pull request: Removed unused agent command AttachVolume...

2015-08-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/743 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Removed unused agent command AttachVolume...

2015-08-27 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/743#issuecomment-135395110 Merging as 2 LGTMs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: Removed unused agent command AttachVolume...

2015-08-27 Thread snuf
Github user snuf commented on the pull request: https://github.com/apache/cloudstack/pull/743#issuecomment-135327593 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: Removed unused agent command AttachVolume...

2015-08-26 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/743#issuecomment-134936442 @koushik-das thanks for replying. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: Removed unused agent command AttachVolume...

2015-08-26 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/743#issuecomment-134930046 @bhaisaab I am not sure what was the exact purpose of these agent commands. I believe these existed even before the code was donated to Apache. But if you look a

[GitHub] cloudstack pull request: Removed unused agent command AttachVolume...

2015-08-26 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/743#issuecomment-134909228 @koushik-das what are the volume attach/detach agent commands, if these are not being used? --- If your project is set up for it, you can reply to this email and h

[GitHub] cloudstack pull request: Removed unused agent command AttachVolume...

2015-08-25 Thread koushik-das
GitHub user koushik-das opened a pull request: https://github.com/apache/cloudstack/pull/743 Removed unused agent command AttachVolumeCommand and corresponding an… …swer AttachVolumeAnswer These types are not used anywhere in the orchestration layer. You can merge this