Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1263
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-209095939
This one looks like it is ready to go now. I will add it to my next 'ready
to merge' batch. Thanks again for all the hard work @GabrielBrascher. :+1:
---
If
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-209084883
I am sorry, but I forgot to update the com.cloud.api.ApiServletTest class,
now that those tests are running, all checks have passed.
@bhaisaab
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-209009495
@GabrielBrascher thanks, Travis failed again. I'll test this on my env
tomorrow (night for me here). Meanwhile, can you build with -T4 -Dnoredist
-Dsimulator
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-208969926
@bhaisaab force pushed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-208956680
@GabrielBrascher can you do a rebase or push -f again so that Travis build
can be re-kicked
---
If your project is set up for it, you can reply to this email and
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-208535036
@GabrielBrascher yes, this is something that we are trying to work through.
We have updated the source to give more verbose logging so we can better
understand the
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-208533273
Travis keeps with the issue *missing file/directory
'/home/travis/build/apache/cloudstack/tools/marvin/dist/Marvin-***.tar.gz*'.
---
If your project is
Github user GabrielBrascher closed the pull request at:
https://github.com/apache/cloudstack/pull/1263
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user GabrielBrascher reopened a pull request:
https://github.com/apache/cloudstack/pull/1263
Removed unused code from com.cloud.api.ApiServer
**Removed â\_â from variables names**: private variables with â\_â
at the beginning is common in C++ but not in Java.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-208339528
@GabrielBrascher could you please close and re-open this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-208332183
can be a polution of the workspace (I'll clean it) or a jenkins having a
different git loaded then is on disk. I've seen the last one once before on an
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-208330435
@DaanHoogland do you know what is going on with jenkins in this case?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-207989355
@DaanHoogland thanks for the tip.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user GabrielBrascher reopened a pull request:
https://github.com/apache/cloudstack/pull/1263
Removed unused code from com.cloud.api.ApiServer
**Removed â\_â from variables names**: private variables with â\_â
at the beginning is common in C++ but not in Java.
Github user GabrielBrascher closed the pull request at:
https://github.com/apache/cloudstack/pull/1263
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-207956609
@GabrielBrascher you could try to close the PR and reopen it. It matters if
the queue at builds.apache.org has a full queue or not.
---
If your project is
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-207914050
Seems that `push -f` is not making the Jenkins and Travis to rerun their
tests. Is there any workaround for that?
---
If your project is set up for it,
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-207490720
Built the package LGTM after review
[INFO]
[INFO] Reactor Summary:
[INFO]
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-207488773
@pdube removed those uderscores, also I modified the
"com.cloud.api.ApiServer.setEncodeApiResponse(boolean)" method to static again.
Thanks.
---
If your
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1263#discussion_r59043684
--- Diff: server/src/com/cloud/api/ApiServlet.java ---
@@ -156,7 +158,7 @@ void processRequestInContext(final HttpServletRequest
req, final
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1263#discussion_r59026874
--- Diff: server/src/com/cloud/api/ApiServlet.java ---
@@ -156,7 +158,7 @@ void processRequestInContext(final HttpServletRequest
req, final
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1263#discussion_r59026830
--- Diff: server/src/com/cloud/api/ApiServer.java ---
@@ -1340,37 +1340,31 @@ public String getSerializedApiError(final
ServerApiException ex, final Map
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1263#discussion_r59026583
--- Diff: server/src/com/cloud/api/ApiServer.java ---
@@ -223,10 +226,7 @@
private static ExecutorService s_executor = new ThreadPoolExecutor(10,
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-207112861
Yes, I think this one is ready. I am trying to get two LGTM code reviews
on every PR, so can one of @DaanHoogland or @pdube give me a LGTM, I have one
from
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-207084266
@swill what about this one?
The tests were already executed and everything passed.
---
If your project is set up for it, you can reply to this email
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-204043787
The code seems ok now. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-203947763
@DaanHoogland @rafaelweingartner @pdube removed those ".class" files, also
all checks have passed.
Thanks.
---
If your project is set up for it, you
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-203492750
@DaanHoogland @rafaelweingartner well noted, I have to remove those
".class" files;
@pdube I am going to verify this checkstyle error.
Thanks.
---
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-203434250
Hi @GabrielBrascher
Travis noted:
Failed during checkstyle execution: There are 1 checkstyle errors.
Have you run *mvn validate* on your code?
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-203406148
@GabrielBrascher, it seems that everything is ok with this PR (giving CI),
but to push it forward with reviews, can you remove the .class from your
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-203396908
@GabrielBrascher you have .class files in your commit according to github.
Can you check?
And please repush anyway? thanks
---
If your project is
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-203392098
### ACS CI BVT Run
**Sumarry:**
Build Number 147
Hypervisor xenserver
NetworkType Advanced
Passed=106
Failed=0
Skipped=4
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-172386387
@rodrigo93 This problem is not from the Jenkins. I am aware with the real
problem (APIChecker bean) just haven't forced to commit again with the
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-172383741
@GabrielBrascher Nice change. It is always good to keep the good
programming practices, especially in a project of this size.
Can you commit it again? It
GitHub user GabrielBrascher opened a pull request:
https://github.com/apache/cloudstack/pull/1263
Removed unused code from com.cloud.api.ApiServer
**Removed â\_â from variables names**: private variables with â\_â
at the beginning is common in C++ but not in Java.
36 matches
Mail list logo
