Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1261#issuecomment-176045236
@remibergsma build/smoke tests passed, constructor definition was changed
with unused variables removed
---
If your project is set up for it, you can reply to
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1261
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1261#issuecomment-175688349
LGTM, dead code remove nice :)
Merging based on 2+LGTMs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1261#issuecomment-175782752
@bhaisaab Why merge without running integration tests? How do we know this
doesn't break anything else?
---
If your project is set up for it, you can reply to
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/1261#issuecomment-172383990
LGMT. Can I give you a suggestion? You could remove those variable
initializing with "_" (underscore) seems that is a common practice in C++
programming.
---
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1261#issuecomment-167047897
Code changes LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
