Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/832#issuecomment-140642411
Hi @borisroman
Few months ago we had a thread on the list to discuss which PR flow we
should have in place in order to increase ACS quality. The
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/825#issuecomment-140332659
Pending travis LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/825
Replaced all occurences of Charset.forName(UTF-8) with
StringUtils.getPreferredCharset().
You can merge this pull request into a Git repository by running:
$ git pull
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/825#issuecomment-140361064
LGTM, thanks @borisroman
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/825
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/825#issuecomment-140388758
Building is passing again:
[INFO]
[INFO] BUILD SUCCESS
[INFO]
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/825#issuecomment-140378109
@borisroman @wido
Was this PR compiled locally? Master is now broken. When I try to build I
get:
BrocadeVcsApi.java:[378,26] error: cannot
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/825#issuecomment-140378819
@wilderrodrigues If something breaks master, any committer can revert it in
order to restore stability. I didn't verify yet, but feel free to revert and
ping
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/825#issuecomment-140380659
Reverted by commit 6e426fa46d8cda50ec76f33429320d4590701678
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/832
Replaced all occurences of Charset.forName(UTF-8) with
StringUtils.getPreferredCharset().
You can merge this pull request into a Git repository by running:
$ git pull
10 matches
Mail list logo
