Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-221151970
@remibergsma ok, no problem. Thanks for the heads up. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-220845474
@swill Some parts need to be rewritten so that won't be on time I'm afraid.
---
If your project is set up for it, you can reply to this email and have your
repl
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-220738113
@remibergsma can you give me a status on this PR. I know you reverted it
because of missing licenses. Should I be trying to wait for this one to get
back in for 4.9
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1482
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-219555677
Thank you. I think that bumps this into my judgement call category. ð
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-219555051
LGTM above from @DaanHoogland as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-219554704
I've done some basic testing of this patch adding and deleting ACLs and
rules within ACLs within VPCs.
LGTM
---
If your project is set up for it, you can rep
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-219537584
@remibergsma would you mind rebasing and re-pushing? We don't have the
reason why Jenkins failed, but Travis passed, so I am considering making a
judgment call on th
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-218852007
@kiwiflyer I'll see if I can get it out completely ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-218838012
ok, I'm just blind and didn't see the additional commit to remove the
forceencaps. :-)
---
If your project is set up for it, you can reply to this email and have
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-218835105
@remibergsma I'm porting this patch set into our 4.8 QA branch currently. I
noticed 709be45 is in here as well (force encap). Can you pull that out of this
set, a
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-218804870
Thanks guys. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-218802890
@swill We'll pull this in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-218794307
@remibergsma can you re-push this one. Jenkins and Travis should be fixed
now, so we should be able to get this green with a new push.
I am missing one code
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-218365323
@remibergsma just a reminder to squash and re-push so we can get jenkins
green. Thx...
---
If your project is set up for it, you can reply to this email and have yo
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-217482470
@remibergsma can you squash this and re-push. I need one more code review
on this one and we should be ready to merge it. Thanks...
---
If your project is set up f
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-216270026
Squash yes, but this can remain open against 4.7 as we are still fixing
bugs and such against 4.7 and it is still supported (until 4.9 is released).
Anything merged
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-216227551
@remibergsma please rebase against master and squash changes to a single
commit
tag:needlove
---
If your project is set up for it, you can reply to this ema
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-215987980
@swill conflict resolved
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-215553431
@remibergsma please rebase as we currently have merge conflicts with
master. Thanks...
---
If your project is set up for it, you can reply to this email and have yo
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-208477870
### CI bubble run
**Commit Reference: 30741a3309da346f324a8f365cb6ef8e1aab39d8**
Looks good to me
---
If your
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1482
Restore iptables at once using iptables-restore instead of calling iptables
numerous times
This makes handling the firewall rules about 50-60 times faster because it
is generated in memory
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1400#issuecomment-196413922
### ACS CI BVT Run
**Sumarry:**
Build Number 94
Hypervisor xenserver
NetworkType Advanced
Passed=102
Failed=16
Skipped=4
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/1400
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1400#issuecomment-179848875
skimmed the code, looks good. I have some questions that might be answerred
by a generic description of how this will improve performance. Could you add
that @
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1400#discussion_r51873540
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs_iptables_save.py
---
@@ -0,0 +1,227 @@
+#!/usr/bin/python
--- End diff --
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1400#issuecomment-179708000
The integration tests succeed and this results in a massive speed
improvement for ACL rules. We've tested it with 500 and 1000 and it's like
50-60 times faster.
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1400
Restore iptables at once using iptables-restore instead of calling iptables
numerous times
You can merge this pull request into a Git repository by running:
$ git pull https://github.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1391#issuecomment-179292599
New PR with additional fixes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/1391
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1391
Restore iptables at once using iptables-restore instead of calling iptables
numerous times
You can merge this pull request into a Git repository by running:
$ git pull https://github.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1389#issuecomment-178507273
thank, don't hurry
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1389#issuecomment-178503500
@DaanHoogland Two errors, one in S2S and one in prv gw. Will reopen in a few
---
If your project is set up for it, you can reply to this email and have your
repl
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1389#issuecomment-178503110
not worth it, @borisroman?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/1389
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1389#issuecomment-178209325
@borisroman
systemvm/patches/debian/config/opt/cloud/bin/cs_iptables_save.py needs a
license.
---
If your project is set up for it, you can reply to th
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1389#issuecomment-178000474
Integration test results:
```
Test router internal advanced zone ... === TestName:
test_02_router_internal_adv | Status : SUCCESS ===
ok
Test
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1389
Restore iptables at once using iptables-restore instead of calling ip
tables numerous times
You can merge this pull request into a Git repository by running:
$ git pull https://github
38 matches
Mail list logo
