Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1143
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1143#issuecomment-160906837
LGTM, merging now since we've 2+ LGTM :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1143#issuecomment-160679884
@pdube Thanks! I didn't know that existed :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1143#issuecomment-160684591
@wido :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user wido opened a pull request:
https://github.com/apache/cloudstack/pull/1143
Show Agent name in Ping response
Before:
DEBUG [c.c.a.m.AgentManagerImpl] (AgentManager-Handler-4:null) Ping
from 66
After:
DEBUG [c.c.a.m.AgentManagerImpl]
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1143#issuecomment-160670527
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1143#issuecomment-160674157
LGTM, but consider using the default log4j formatter. ex:
`logger.debug("Ping from {} ({})", hostid, hostname);`
and extracting the message to a constant
---
