Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1058#issuecomment-158854458
@remibergsma thanks, will merge this on 4.5 soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1058#issuecomment-158752741
This was merged to 4.6, then to master as it is a security improvement that
applied cleanly.
@bhaisaab You may want to include this in the final 4.5 rel
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1058
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1058#issuecomment-158752169
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first). Screenshot is from an experimental Jenkins job (that runs the
same tests
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1058#issuecomment-158530260
I will run some tests on this branch and report back.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1058#issuecomment-155739860
@wido @ustcweizhou I see two "looks good to me" without validation test
explenation. Did you guys test this and how?
---
If your project is set up for it, you
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1058#issuecomment-155739176
LGTM
nice!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1058#issuecomment-155702537
LGTM to me. Simple fix to make passwords more secure
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user nnesic opened a pull request:
https://github.com/apache/cloudstack/pull/1058
Shuffling the password to avoid having a subset of characters in fixed
positions.
Related to CLOUDSTACK-9052.
I am shuffling the characters in the password, to avoid having a certain
c
