[GitHub] cloudstack pull request: Support live migration on older version o...

Github user mike-tutkowski closed the pull request at: https://github.com/apache/cloudstack/pull/767 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Support live migration on older version o...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/767#issuecomment-136877843 Rohit - I just submitted https://github.com/apache/cloudstack/pull/771/files for the support of live migration on older versions of Libvirt in CS 4.5.

[GitHub] cloudstack pull request: Support live migration on older version o...

GitHub user mike-tutkowski opened a pull request: https://github.com/apache/cloudstack/pull/771 Support live migration on older version of Libvirt https://issues.apache.org/jira/browse/CLOUDSTACK-8792 A flag being passed to Libvirt assumes v1.0.0 or later. We need

[GitHub] cloudstack pull request: Support live migration on older version o...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/767#discussion_r38395369 --- Diff: plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java --- @@ -1273,10 +1274,20 @@ public void

[GitHub] cloudstack pull request: Support live migration on older version o...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/767#issuecomment-136684709 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: Support live migration on older version o...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/767#issuecomment-136686420 @mike-tutkowski I've merged this on master, cherry-pick failing on 4.5 branch; can you send a new PR for 4.5 branch? --- If your project is set up for it, you can

[GitHub] cloudstack pull request: Support live migration on older version o...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/767#discussion_r38414670 --- Diff: plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java --- @@ -1273,10 +1274,20 @@ public

[GitHub] cloudstack pull request: Support live migration on older version o...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/771 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Support live migration on older version o...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/771#issuecomment-136933433 LGTM @mike-tutkowski thanks, since the same was merged on master; will merge this on 4.5 today --- If your project is set up for it, you can reply to this email

Re: [GitHub] cloudstack pull request: Support live migration on older version o...

Cool...sounds good - thanks for merging. On Tue, Sep 1, 2015 at 10:16 PM, bhaisaab wrote: > Github user bhaisaab commented on the pull request: > > https://github.com/apache/cloudstack/pull/771#issuecomment-136933433 > > LGTM @mike-tutkowski thanks, since the same

[GitHub] cloudstack pull request: Support live migration on older version o...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/767#issuecomment-136940141 May be there is some issue with ACS or github. I also noticed that commits are not getting closed on merge and @hubot is marking it as merged after sometime.

[GitHub] cloudstack pull request: Support live migration on older version o...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/767#issuecomment-136939528 Something went wrong in this PR, why is @hubot here and not asfgit? The PR is still getting listed in the list of open PRs, even though it has been merged on

Re: [GitHub] cloudstack pull request: Support live migration on older version o...

Sure, I can submit a follow-up PR for 4.5. On Tuesday, September 1, 2015, bhaisaab wrote: > Github user bhaisaab commented on the pull request: > > https://github.com/apache/cloudstack/pull/767#issuecomment-136686420 > > @mike-tutkowski I've merged this on master,

[GitHub] cloudstack pull request: Support live migration on older version o...

GitHub user mike-tutkowski opened a pull request: https://github.com/apache/cloudstack/pull/767 Support live migration on older version of Libvirt https://issues.apache.org/jira/browse/CLOUDSTACK-8792 A flag being passed to Libvirt assumes v1.0.0 or later. We need

[GitHub] cloudstack pull request: Support live migration on older version o...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/767#issuecomment-136585198 LGTM, whoever merged, please merge on 4.5 branch as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as