Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/810
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ashwinswaroop commented on the pull request:
https://github.com/apache/cloudstack/pull/810#issuecomment-139910486
@rafaelweingartner I committed and pushed the new changes. I also changed
the commit comment like you requested.
---
If your project is set up for it, you
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/810#issuecomment-139913021
Now the change seems ok.
I would just suggest you to squash the two commits, and fix the commit
message (the first line of the comment is used to
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/810#issuecomment-139913727
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/810#issuecomment-139914742
Automatically merged?!?
I think it would be better to have merged, just after the squash
---
If your project is set up for it, you can reply to this
Github user ashwinswaroop commented on the pull request:
https://github.com/apache/cloudstack/pull/810#issuecomment-139927888
@resmo Do you know the reason for the 2 aborted messages above? Is there
anything I should do?
---
If your project is set up for it, you can reply to this
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/810#issuecomment-139921174
@ashwinswaroop,
Well, now I have no idea what to do. Letâs hope someone with more
experience reply to this thread.
---
If your project is set up
Github user ashwinswaroop commented on the pull request:
https://github.com/apache/cloudstack/pull/810#issuecomment-139920903
@rafaelweingartner Okay so should I still squash the commits or leave it as
it is since it says the pull request has been merged and closed? Also I
received
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/810#issuecomment-139969167
builds were aborted probably because the PR was merged.
This PR is properly merged to master with below commits
* | | 120e1cc Merge pull request #810
GitHub user ashwinswaroop opened a pull request:
https://github.com/apache/cloudstack/pull/810
This is the fix for the JIRA issue CLOUDSTACK-8817.
This is my first contribution to Apache CloudStack. The return values for
endpoint and startpoint have now been changed to Integer
Github user ashwinswaroop commented on the pull request:
https://github.com/apache/cloudstack/pull/810#issuecomment-139697149
Sorry for not changing the setter. I'm using eclipse now and I can see that
there is a FirewallResponse.java file in both cloud and cloudstack-api. Should
I
Github user ashwinswaroop commented on the pull request:
https://github.com/apache/cloudstack/pull/810#issuecomment-139703362
Okay that makes sense. I went through the entire project and found only one
caller of setStartPort and setEndPort which was from the relevant
class(Firewall
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/810#issuecomment-139698329
@ashwinswaroop, no problem.
About the class duplicity, it just seems that there are two classes, but in
reality there is only one. The question is
13 matches
Mail list logo
