[GitHub] cloudstack pull request: Update ConsoleProxyPasswordBasedEncryptor...

2015-04-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Update ConsoleProxyPasswordBasedEncryptor...

2015-04-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Update ConsoleProxyPasswordBasedEncryptor...

2015-03-04 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/10#issuecomment-77123920 I dont think the main methods are required. Looks like they are there only for testing. may be we should just delete the main methods. --- If your project is set up

[GitHub] cloudstack pull request: Update ConsoleProxyPasswordBasedEncryptor...

2014-12-08 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/10#issuecomment-66041100 Hi Tim, IMO, the fixes are in main methods of those classes, so do they even affect CloudStack mgmt server, I'm not sure? Both the PRs cannot be

[GitHub] cloudstack pull request: Update ConsoleProxyPasswordBasedEncryptor...

2014-12-07 Thread TimRots
Github user TimRots commented on the pull request: https://github.com/apache/cloudstack/pull/10#issuecomment-65944285 Hi Rohit, What does this PR do? Fix bad practice demonstration What is the issue and what does this fix do? The main method demonstrates

[GitHub] cloudstack pull request: Update ConsoleProxyPasswordBasedEncryptor...

2014-12-05 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/10#issuecomment-65823752 What does this PR do? What is the issue and what does this fix do? This is same as #11 please close one of them. Thanks. --- If your project is set up for it,