Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1148#issuecomment-222390201
### ACS CI BVT Run
**Sumarry:**
Build Number 84
Hypervisor xenserver
NetworkType Advanced
Passed=73
Failed=0
Skipped=3
_
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1148#issuecomment-216205836
LGTM, @wenwenxiong can you rebase against latest master and share state of
your PR, thanks
tag:easypr
---
If your project is set up for it, you can reply to
Github user rodrigo93 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1148#discussion_r50638624
--- Diff:
plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java
---
@@ -2841,8 +2841,9 @@ private boolean
manag
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/1148#issuecomment-174321124
Hi @wenwenxiong, could you make a Jira for this PR?
Did you make any test?
---
If your project is set up for it, you can reply to this email and have your
r
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1148#issuecomment-162344831
@wenwenxiong can you add tests and or test data to this? any combination of
- unit tests
- marvin tests
- test procedure
thanks
---
If you
GitHub user wenwenxiong opened a pull request:
https://github.com/apache/cloudstack/pull/1148
Update JuniperSrxResource.java
fix "action" will not relace in xml
if type.equals(SecurityPolicyType.SECURITYPOLICY_EGRESS_DEFAULT)
You can merge this pull request into a Git reposit
