[GitHub] cloudstack pull request: Update NiciraNvpGuestNetworkGuru.java

2015-07-30 Thread kishankavala
Github user kishankavala commented on the pull request: https://github.com/apache/cloudstack/pull/636#issuecomment-126288404 @sspans Since Test case is updated to cover VXLAN also, LGTM. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: Update NiciraNvpGuestNetworkGuru.java

2015-07-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/636 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Update NiciraNvpGuestNetworkGuru.java

2015-07-30 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/636#issuecomment-126250367 @sspans yes but they might be tempted to do some vxlanning after upgrading ACS not upgrading NSX . what would happen? --- If your project is set up for it,

[GitHub] cloudstack pull request: Update NiciraNvpGuestNetworkGuru.java

2015-07-30 Thread sspans
Github user sspans commented on the pull request: https://github.com/apache/cloudstack/pull/636#issuecomment-126250153 Testing and a unit-test will still be added. We need this feature because we're planning to roll out new zones with VXLAN, which if the changes remain

[GitHub] cloudstack pull request: Update NiciraNvpGuestNetworkGuru.java

2015-07-30 Thread sspans
Github user sspans commented on the pull request: https://github.com/apache/cloudstack/pull/636#issuecomment-126257887 The plugin would fail, similar to how it fails now when you ask ik to do vxlan when it only supports STT. The encapsulation type is something that you first

[GitHub] cloudstack pull request: Update NiciraNvpGuestNetworkGuru.java

2015-07-30 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/636#issuecomment-126258728 ok --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: Update NiciraNvpGuestNetworkGuru.java

2015-07-30 Thread sspans
Github user sspans commented on the pull request: https://github.com/apache/cloudstack/pull/636#issuecomment-126247958 Daan: any supported release of vmware nsx will support VXLAN. People running older releases probably already have an STT setup running, and should not encounter