[GitHub] cloudstack pull request: When no zone name is available display a ...

GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1477 When no zone name is available display a default When a zone name is available, the previous behaviour is still there: ![screen shot 2016-03-30 at 21 00 44](https://cloud.githubusercont

[GitHub] cloudstack pull request: When no zone name is available display a ...

Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1477#issuecomment-213822378 LGTM. Do you think we should translate this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] cloudstack pull request: When no zone name is available display a ...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1477#issuecomment-216227415 LGTM A manual UI testing is needed tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] cloudstack pull request: When no zone name is available display a ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1477#issuecomment-216228565 I think this is ready to merge. @remibergsma has shown screenshots to verify the UI change does what it is supposed to and we have the LGTMs required. --- If your p

[GitHub] cloudstack pull request: When no zone name is available display a ...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1477#issuecomment-216232227 @swill apart from the PR author, it would be great if at least one more reviewer can share a screenshot; please proceed as per your discretion --- If your project is

[GitHub] cloudstack pull request: When no zone name is available display a ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1477#issuecomment-216233168 @rhtyd in general, I agree with you. The main blocker with that is the fact that very few people have the ability to test regional templates. The code is pretty str

[GitHub] cloudstack pull request: When no zone name is available display a ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1477#issuecomment-217471150 Unless someone is able to verify this, I think we have to take the screenshots from @remibergsma as verification. Not very many people have the ability to test regio

[GitHub] cloudstack pull request: When no zone name is available display a ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1477#issuecomment-218365520 I am going to merge this one. I am confident with the change and I have verification from @remibergsma, so I think we are good to go on this one. --- If your proj

[GitHub] cloudstack pull request: When no zone name is available display a ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1477 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is