Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/599
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/599#issuecomment-122242828
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/599#discussion_r34877501
--- Diff: framework/db/src/com/cloud/utils/db/Merovingian2.java ---
@@ -63,9 +63,7 @@
private Merovingian2(long msId) {
super(Mer
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/599#discussion_r34875009
--- Diff: framework/db/src/com/cloud/utils/db/Merovingian2.java ---
@@ -63,9 +63,7 @@
private Merovingian2(long msId) {
super(Me
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/599#discussion_r34874962
--- Diff: framework/db/src/com/cloud/utils/db/Merovingian2.java ---
@@ -63,9 +63,7 @@
private Merovingian2(long msId) {
super(Me
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/599#discussion_r34873680
--- Diff: framework/db/src/com/cloud/utils/db/Merovingian2.java ---
@@ -63,9 +63,7 @@
private Merovingian2(long msId) {
super(Mer
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/599#discussion_r34872122
--- Diff: framework/db/src/com/cloud/utils/db/Merovingian2.java ---
@@ -63,9 +63,7 @@
private Merovingian2(long msId) {
super(Me
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/599#discussion_r34870126
--- Diff: framework/db/src/com/cloud/utils/db/Merovingian2.java ---
@@ -63,9 +63,7 @@
private Merovingian2(long msId) {
super(Mer
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/599#issuecomment-122030264
I checked all 5 Travis jobs and they failed due to timeout. Thus, it LGTM
:+1:
