[GitHub] cloudstack pull request: coverity issues in old upgrade code

2015-08-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/603 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: coverity issues in old upgrade code

2015-08-03 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/603#issuecomment-127378233 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: coverity issues in old upgrade code

2015-08-03 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/603#issuecomment-127171961 Went through the file, had just one remark which won't cause trouble. I would rather remove the old code other them keeping it commented out. But that's just