Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/467#issuecomment-120495209
@DaanHoogland was this committed to master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/467#issuecomment-120524298
yes this is on master. is there doubt?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/467#issuecomment-120541217
@DaanHoogland some weird confusion, nevermind
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/467
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
yeah, I hate that naming convention but I'll remove the _ from the name.
On Thu, Jun 18, 2015 at 5:50 AM, karuturi g...@git.apache.org wrote:
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/467#issuecomment-113027041
@DaanHoogland looks
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/467#issuecomment-113027041
@DaanHoogland looks like you split the commit :) (the combined one was also
ok. )
I see some checkstyle errors in the jenkins build
[INFO] ---
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/467#discussion_r32616885
--- Diff: utils/src/com/cloud/utils/StringUtils.java ---
@@ -32,6 +33,21 @@
public class StringUtils {
private static final char[]
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/467#discussion_r32618313
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
---
@@ -1094,13 +1092,6 @@ private String
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/467#issuecomment-112767792
since its a [try-with-resources
Statement](http://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html),
it will get closed
---
If your
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/467#discussion_r32617440
--- Diff: utils/src/com/cloud/utils/StringUtils.java ---
@@ -32,6 +33,21 @@
public class StringUtils {
private static final char[]
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/467#discussion_r32617957
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
---
@@ -1094,13 +1092,6 @@ private String
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/467#discussion_r32618952
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
---
@@ -1094,13 +1092,6 @@ private String
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/467
findbugs: deal with all the encoding issues in a unified way
further getBytes() calls can
getBytes(StringUtils.getPrefferedCharset()) instead
You can merge this pull request into a
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/467#issuecomment-112795850
I seem to have messed up here and put two unrelated commits in one pr.
@karuturi, you want me to clean up my mess or can we merge it like this?
---
If your
14 matches
Mail list logo
