Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1427
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1427#issuecomment-204046109
#1438 covers this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user pvr9711 commented on the pull request:
https://github.com/apache/cloudstack/pull/1427#issuecomment-198490086
LGTM
Ran BVT with XS 6.5 - all the test passed with the exception of the
following tests due to env issues:
test_01_create_volume - ssh issue.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1427#issuecomment-191424588
Haha. Fair enough. I will let Raja test, but otherwise it LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1427#issuecomment-19145
:) @swill it is the only part I typed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1427#issuecomment-191389512
It looks like your IDE had a field day with this class. So other than the
reordering of imports, adding `final` to a ton of variables and removing some
unneeded
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/1427
findbugs: new found old instance of DM_DEFAULT_ENCODING fixed
this quick fix to silence the findbugs
which seems to think this is a new issue
You can merge this pull request into
