Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/490
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/490#discussion_r32825228
--- Diff:
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java ---
@@ -391,6 +391,32 @@ private static void tagCommand(Command
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/490
findbugs UC useless condition
not sure what findbugs means yet, is it negating the if-condition against
the assert?
This should at least turn both warnings into one.
You can merge
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/490#discussion_r32824227
--- Diff:
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java ---
@@ -391,6 +391,32 @@ private static void tagCommand(Command cmd) {
