[GitHub] cloudstack pull request: javascript:TrailingComma sonacube issue c...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1069 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: javascript:TrailingComma sonacube issue c...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1069#issuecomment-158915937 LGTM, built a cloud on this PR and clicked through the UI which worked fine. ![screen shot 2015-11-23 at 13 05 07](https://cloud.githubusercontent.com/a

[GitHub] cloudstack pull request: javascript:TrailingComma sonacube issue c...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1069#issuecomment-158874631 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cloudstack pull request: javascript:TrailingComma sonacube issue c...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1069#issuecomment-158403924 The fix seems good to me. I would like to LGTM, but I can't test JavaScript that easily. Isn't there a lint-check for JS? --- If your project is set up for i

[GitHub] cloudstack pull request: javascript:TrailingComma sonacube issue c...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1069#issuecomment-158375503 LGTM based on the changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] cloudstack pull request: javascript:TrailingComma sonacube issue c...

GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/1069 javascript:TrailingComma sonacube issue considered blocker removed simple change in several locations You can merge this pull request into a Git repository by running: $ git pull http