Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1437#issuecomment-221871305
I think the only thing we are missing with this one is verification that
the change works and does not break anything. @pedro-martins is there anything
you can
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/1437#issuecomment-221841462
LGTM. This file seems to be remains from the previous attempt of HyperV
support which was talking to SCVMM.
---
If your project is set up for it, you can reply
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1437#issuecomment-219696525
@anshul1886 @anshulgangwar Can you review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1437#issuecomment-216291321
I don't have the ability to test HyperV. Can anyone verify this PR for me?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1437#issuecomment-216225500
A CI testing (one with HyperV) should confirm if this PR can be accepted
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1437#issuecomment-195626691
I also got your point ;). Once you open an exception, there are people that
may try to abuse it.
Here we might be able to get our hands on Hyper-V
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1437#issuecomment-195625848
I see your point @rafaelweingartner, no hard feelings here. If we simply
always run the integration tests, there is no discussion whether or not we need
to run
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1437#issuecomment-195620877
@remibergsma,
Letâs be reasonable, when you remove a method/class or something else,
that do not have any reference anywhere in the code, in my
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1437#issuecomment-195620065
@GabrielBrascher based on what tests? It was only compiled.
I'm with @eriweb here, this should not go in without testing. Ask on the ML
if someone with
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1437#issuecomment-195618530
Given that @pedro-martins had no problems on running tests, the code LGTM.
---
If your project is set up for it, you can reply to this email and have your
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1437#issuecomment-195369454
@eriweb I saw the Jenkins build, and it was ok, that meant the code
compiled and all of the tests cases (unit and integration tests) were executed
Github user pedro-martins commented on the pull request:
https://github.com/apache/cloudstack/pull/1437#issuecomment-195364975
Hi @eriweb, thanks for reviewing this PR.
I did a maven install in the ACS project and it built and ran all tests
cases with no errors. But I didn't
Github user eriweb commented on the pull request:
https://github.com/apache/cloudstack/pull/1437#issuecomment-195361874
@rafaelweingartner that's not really an answer, and I stand my question.
Have you done any testing? does the code compile? does unit tests run?
The
Github user pedro-martins commented on the pull request:
https://github.com/apache/cloudstack/pull/1437#issuecomment-195361064
@rafaelweingartner ty for your review.
Changed the log message.
Ty.
---
If your project is set up for it, you can reply to this email and
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1437#issuecomment-195095474
@eriweb
There are things that do not need to be tested, we work in computer
science; if there is no reference to an object/class, there is no way it
Github user eriweb commented on the pull request:
https://github.com/apache/cloudstack/pull/1437#issuecomment-195069715
Have you done any testing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user pedro-martins opened a pull request:
https://github.com/apache/cloudstack/pull/1437
removed unused HypervDummyResourceBase class
Was removed the class
com.cloud.hypervisor.hyperv.resource.HypervDummyResourceBase
- This class do not have the annotation
17 matches
Mail list logo
