GitHub user cloudtrends opened a pull request:
https://github.com/apache/cloudstack/pull/66
under windows environment the publicKeyPath and privateKeyPath should
replace from \...
Under windows environment the publicKeyPath and privateKeyPath should
replace from \ to / when send
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/66#discussion_r22932649
--- Diff: server/src/com/cloud/server/ConfigurationServerImpl.java ---
@@ -894,6 +894,13 @@ protected void
injectSshKeysIntoSystemVmIsoPatch(String public
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/66#discussion_r22932788
--- Diff: server/src/com/cloud/server/ConfigurationServerImpl.java ---
@@ -894,6 +894,13 @@ protected void
injectSshKeysIntoSystemVmIsoPatch(String public
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/66#issuecomment-69908275
In case of windows, python scripts are executed and I think it runs fine
from cygwin. Is this change targeted to make it work from cmd?
---
If your project is set up
Github user cloudtrends commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/66#discussion_r22991914
--- Diff: server/src/com/cloud/server/ConfigurationServerImpl.java ---
@@ -894,6 +894,13 @@ protected void
injectSshKeysIntoSystemVmIsoPatch(String pub
Github user cloudtrends commented on the pull request:
https://github.com/apache/cloudstack/pull/66#issuecomment-70043494
My test environment is on Windows 2008 & cygwin 64 bits version .
I can reoccur the error's by below python scripts:
--- c
Github user cloudtrends commented on the pull request:
https://github.com/apache/cloudstack/pull/66#issuecomment-70043778
Hi karuturi ,
thanks for point out that I should use isOnWindows function , very
appreciation.
ChunFeng
---
If your project is set up for
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/66#issuecomment-70210894
Thanks for the patch. Agree to the slash change. I am pushing this to
master(4.6). Let me know if you want it on any other branch.
---
If your project is set up for
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/66
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
