[GitHub] cloudstack pull request: update for comment in cancelMaintin on st...

2015-11-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1065 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: update for comment in cancelMaintin on st...

2015-11-13 Thread wenwenxiong
GitHub user wenwenxiong opened a pull request: https://github.com/apache/cloudstack/pull/1065 update for comment in cancelMaintin on start VR change comment //if the instance is of type ssvm, call the ssvm manager to //if the instance is of type domain router vm, call

[GitHub] cloudstack pull request: update for comment in cancelMaintin on st...

2015-11-13 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1065#issuecomment-156388025 Harmless commit, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: update for comment in cancelMaintin on st...

2015-11-13 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1065#issuecomment-156394882 LGTM :+1: Improving comments, always :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: update for comment in cancelMaintin on st...

2015-11-13 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1065#issuecomment-156400401 Not sure if we need this comment but the old version was a harmfull misqguidance, the new one is correct. LGTM --- If your project is set up for it, you can