[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2017-02-16 Thread mike-tutkowski
Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r101596817 --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java --- @@ -2909,51 +2911,21 @@ public Vlan doInTransaction(final Transact

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1579 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-02 Thread fmaximus
Github user fmaximus commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90624351 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java --- @@ -0,0 +1,310 @@ +// +// Li

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-02 Thread fmaximus
Github user fmaximus commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90623492 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java --- @@ -0,0 +1,310 @@ +// +// Li

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-02 Thread fmaximus
Github user fmaximus commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90623476 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java --- @@ -0,0 +1,310 @@ +// +// Li

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-02 Thread fmaximus
Github user fmaximus commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90619259 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java --- @@ -0,0 +1,310 @@ +// +// Li

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread sgoeminn
Github user sgoeminn commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90520113 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java --- @@ -0,0 +1,310 @@ +// +// Li

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread sgoeminn
Github user sgoeminn commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90510869 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/UpdateNuageVspDeviceCommand.java --- @@ -0,0 +1,43 @@ +// +// Lice

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread sgoeminn
Github user sgoeminn commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90510701 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/CleanUpDomainCommand.java --- @@ -0,0 +1,63 @@ +// +// Licensed to

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread sgoeminn
Github user sgoeminn commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90510516 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -387,41 +400,39 @@ public boolean canEnableIndiv

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread sgoeminn
Github user sgoeminn commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90509963 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -387,41 +400,39 @@ public boolean canEnableIndiv

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90457477 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java --- @@ -0,0 +1,310 @@ +// +// Li

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90454905 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspRequestWrapper.java --- @@ -0,0 +1,78 @@ +// +// Licensed t

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90455598 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java --- @@ -0,0 +1,310 @@ +// +// Li

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90452488 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -255,7 +284,30 @@ public void reserve(NicP

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90456898 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java --- @@ -0,0 +1,310 @@ +// +// Li

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90451456 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/UpdateNuageVspDeviceCommand.java --- @@ -0,0 +1,43 @@ +// +// Lice

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90452834 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -317,20 +368,28 @@ private void updateDhcp

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90451924 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -387,41 +400,39 @@ public boolean canEnableIndiv

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90450632 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -128,6 +135,26 @@ private static

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90455612 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java --- @@ -0,0 +1,310 @@ +// +// Li

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90450815 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/CleanUpDomainCommand.java --- @@ -0,0 +1,63 @@ +// +// Licensed to

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90455401 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java --- @@ -0,0 +1,310 @@ +// +// Li

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90455021 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspRequestWrapper.java --- @@ -0,0 +1,78 @@ +// +// Licensed t

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90450669 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -128,6 +135,26 @@ private static

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90450606 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -128,6 +135,26 @@ private static

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90451522 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/UpdateNuageVspDeviceCommand.java --- @@ -0,0 +1,43 @@ +// +// Lice

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90453536 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -339,34 +398,63 @@ private void updateDhcp

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90458374 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java --- @@ -0,0 +1,310 @@ +// +// Li

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90453232 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -339,34 +398,63 @@ private void updateDhcp

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90451818 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -387,41 +400,39 @@ public boolean canEnableIndiv

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90451387 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/UpdateNuageVspDeviceCommand.java --- @@ -0,0 +1,43 @@ +// +// Lice

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90457155 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java --- @@ -0,0 +1,310 @@ +// +// Li

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90457877 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java --- @@ -0,0 +1,310 @@ +// +// Li

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90451135 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/CleanUpDomainCommand.java --- @@ -0,0 +1,63 @@ +// +// Licensed to

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90450578 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -128,6 +135,26 @@ private static

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90450802 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/CleanUpDomainCommand.java --- @@ -0,0 +1,63 @@ +// +// Licensed to

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread prashanthvarma
Github user prashanthvarma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r9043 --- Diff: server/src/com/cloud/network/NetworkModelImpl.java --- @@ -1558,6 +1558,32 @@ public boolean checkIpForService(IpAddress userIp, Service

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-11-30 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90394494 --- Diff: api/src/com/cloud/network/Network.java --- @@ -215,6 +216,8 @@ public static Provider getProvider(String providerName) { public stat

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-11-30 Thread fmaximus
Github user fmaximus commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90236739 --- Diff: api/src/com/cloud/network/Network.java --- @@ -215,6 +216,8 @@ public static Provider getProvider(String providerName) { public s

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-11-30 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90227580 --- Diff: client/pom.xml --- @@ -168,6 +168,11 @@ org.apache.cloudstack + cloud-plugin-network-vsp --- End diff

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-11-30 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90220642 --- Diff: engine/schema/src/com/cloud/offerings/NetworkOfferingVO.java --- @@ -142,6 +142,9 @@ @Column(name="supports_streched_l2") boolea

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-11-30 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90220265 --- Diff: api/src/org/apache/cloudstack/api/response/NetworkOfferingResponse.java --- @@ -120,6 +120,10 @@ @Param(description = "true if network o

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-11-30 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90220227 --- Diff: api/src/org/apache/cloudstack/api/ApiConstants.java --- @@ -639,6 +639,7 @@ public static final String READ_ONLY = "readonly"; p

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-11-30 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90221275 --- Diff: setup/db/db/schema-4910to41000.sql --- @@ -45,4 +45,6 @@ CREATE TABLE `cloud`.`vlan_details` ( `display` tinyint(1) NOT NULL DEFAULT 1 COMM

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-11-30 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90220849 --- Diff: api/src/com/cloud/network/Network.java --- @@ -215,6 +216,8 @@ public static Provider getProvider(String providerName) { public stat

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-11-30 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90221096 --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java --- @@ -2968,8 +2939,45 @@ public Vlan doInTransaction(final TransactionStatus

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-11-30 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90220410 --- Diff: client/pom.xml --- @@ -168,6 +168,11 @@ org.apache.cloudstack + cloud-plugin-network-vsp --- End diff

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-11-30 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90221150 --- Diff: server/src/com/cloud/network/NetworkModelImpl.java --- @@ -1558,6 +1558,32 @@ public boolean checkIpForService(IpAddress userIp, Service service,

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-08-09 Thread nlivens
Github user nlivens closed the pull request at: https://github.com/apache/cloudstack/pull/1579 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-08-09 Thread nlivens
GitHub user nlivens reopened a pull request: https://github.com/apache/cloudstack/pull/1579 CLOUDSTACK-9403 : Support for shared networks in Nuage VSP plugin This is first phase of support of Shared Network in cloudstack through NuageVsp Network Plugin. A shared network is a type of

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-07-14 Thread nlivens
Github user nlivens closed the pull request at: https://github.com/apache/cloudstack/pull/1579 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-07-14 Thread nlivens
GitHub user nlivens reopened a pull request: https://github.com/apache/cloudstack/pull/1579 CLOUDSTACK-9403 : Support for shared networks in Nuage VSP plugin This is first phase of support of Shared Network in cloudstack through NuageVsp Network Plugin. A shared network is a type of

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-06-02 Thread nlivens
GitHub user nlivens opened a pull request: https://github.com/apache/cloudstack/pull/1579 CLOUDSTACK-9403 : Support for shared networks in Nuage VSP plugin Test Results are:- Valiate that ROOT admin is NOT able to deploy a VM for a user in ROOT domain in a shared network with ..