[GitHub] cloudstack pull request #1594: CLOUDSTACK-9407: vm_network_map table doesnt ...

2016-07-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1594 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request #1594: CLOUDSTACK-9407: vm_network_map table doesnt ...

2016-06-21 Thread nvazquez
Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1594#discussion_r67907402 --- Diff: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java --- @@ -1577,8 +1577,9 @@ private void advanceStop(final VMInstanceVO

[GitHub] cloudstack pull request #1594: CLOUDSTACK-9407: vm_network_map table doesnt ...

2016-06-21 Thread nvazquez
Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1594#discussion_r67907224 --- Diff: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java --- @@ -1577,8 +1577,9 @@ private void advanceStop(final VMInstanceVO

[GitHub] cloudstack pull request #1594: CLOUDSTACK-9407: vm_network_map table doesnt ...

2016-06-21 Thread nvazquez
Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1594#discussion_r67907159 --- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java --- @@ -2086,6 +2089,18 @@ public boolean expunge(UserVmVO vm, long callerUserId, Account

[GitHub] cloudstack pull request #1594: CLOUDSTACK-9407: vm_network_map table doesnt ...

2016-06-17 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1594#discussion_r67572107 --- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java --- @@ -2086,6 +2089,18 @@ public boolean expunge(UserVmVO vm, long callerUserId, Account

[GitHub] cloudstack pull request #1594: CLOUDSTACK-9407: vm_network_map table doesnt ...

2016-06-17 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1594#discussion_r67571914 --- Diff: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java --- @@ -1577,8 +1577,9 @@ private void advanceStop(final VMInstanceVO

[GitHub] cloudstack pull request #1594: CLOUDSTACK-9407: vm_network_map table doesnt ...

2016-06-17 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1594#discussion_r67571985 --- Diff: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java --- @@ -1577,8 +1577,9 @@ private void advanceStop(final VMInstanceVO

[GitHub] cloudstack pull request #1594: CLOUDSTACK-9407: vm_network_map table doesnt ...

2016-06-16 Thread nvazquez
GitHub user nvazquez opened a pull request: https://github.com/apache/cloudstack/pull/1594 CLOUDSTACK-9407: vm_network_map table doesnt get cleaned up properly JIRA TICKET: https://issues.apache.org/jira/browse/CLOUDSTACK-9407 ### Introduction It was found out that in