[GitHub] cloudstack pull request #1730: VMTemplateZone needs some love

2016-11-09 Thread marcaurele
Github user marcaurele commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1730#discussion_r87170352 --- Diff: engine/schema/src/com/cloud/storage/dao/VMTemplateZoneDaoImpl.java --- @@ -84,14 +84,11 @@ public VMTemplateZoneVO findByZoneTemplate(long z

[GitHub] cloudstack pull request #1730: VMTemplateZone needs some love

2016-11-02 Thread marcaurele
Github user marcaurele commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1730#discussion_r86242383 --- Diff: engine/schema/src/com/cloud/storage/dao/VMTemplateZoneDaoImpl.java --- @@ -84,14 +84,11 @@ public VMTemplateZoneVO findByZoneTemplate(long z

[GitHub] cloudstack pull request #1730: VMTemplateZone needs some love

2016-10-25 Thread marcaurele
GitHub user marcaurele opened a pull request: https://github.com/apache/cloudstack/pull/1730 VMTemplateZone needs some love It's incorrect to use the findIncludingRemovedBy and listIncludingRemovedBy for the common list and find operation. Moreover the DAO is trying to update