[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread nitin-maharana
Github user nitin-maharana commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1859#discussion_r93749580 --- Diff: ui/scripts/configuration.js --- @@ -2640,12 +2640,30 @@ }

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread rajesh-battala
Github user rajesh-battala commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1859#discussion_r93747510 --- Diff: plugins/network-elements/netscaler/src/com/cloud/network/NetScalerControlCenterVO.java --- @@ -0,0 +1,129 @@ +// Licensed to the

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread rajesh-battala
Github user rajesh-battala commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1859#discussion_r93747256 --- Diff: plugins/network-elements/netscaler/src/com/cloud/api/commands/DeployNetscalerVpxCmd.java --- @@ -0,0 +1,149 @@ +// Licensed to the

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread rajesh-battala
Github user rajesh-battala commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1859#discussion_r93746791 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixStartCommandWrapper.java --- @@ -87,7

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread rajesh-battala
Github user rajesh-battala commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1859#discussion_r93747990 --- Diff: server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java --- @@ -1157,14 +1222,28 @@ protected IpDeployer

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread rajesh-battala
Github user rajesh-battala commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1859#discussion_r93747579 --- Diff: plugins/network-elements/netscaler/src/com/cloud/network/dao/NetScalerServicePackageDaoImpl.java --- @@ -0,0 +1,72 @@ +// Licensed

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread rajesh-battala
Github user rajesh-battala commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1859#discussion_r93747566 --- Diff: plugins/network-elements/netscaler/src/com/cloud/network/dao/NetScalerServicePackageDaoImpl.java --- @@ -0,0 +1,72 @@ +// Licensed

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread rajesh-battala
Github user rajesh-battala commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1859#discussion_r93746916 --- Diff: plugins/network-elements/netscaler/src/com/cloud/api/commands/DeleteServicePackageOfferingCmd.java --- @@ -0,0 +1,95 @@ +//

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread rajesh-battala
Github user rajesh-battala commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1859#discussion_r93746847 --- Diff: plugins/network-elements/netscaler/src/com/cloud/api/commands/DeleteNetscalerControlCenterCmd.java --- @@ -0,0 +1,98 @@ +//

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread rajesh-battala
Github user rajesh-battala commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1859#discussion_r93747795 --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java --- @@ -4781,6 +4818,12 @@ public boolean deleteNetworkOffering(final

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread rajesh-battala
Github user rajesh-battala commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1859#discussion_r93747692 --- Diff: plugins/network-elements/netscaler/src/com/cloud/network/vm/NetScalerVMManager.java --- @@ -0,0 +1,86 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread rajesh-battala
Github user rajesh-battala commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1859#discussion_r93747629 --- Diff: plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerLoadBalancerElementService.java --- @@ -71,4 +121,29 @@

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread rajesh-battala
Github user rajesh-battala commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1859#discussion_r93747870 --- Diff: server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java --- @@ -900,6 +945,17 @@ public boolean

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread rajesh-battala
Github user rajesh-battala commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1859#discussion_r93746542 --- Diff: engine/schema/src/com/cloud/dc/dao/DataCenterIpAddressDaoImpl.java --- @@ -177,6 +177,22 @@ public void releaseIpAddress(long nicId,

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread rajesh-battala
Github user rajesh-battala commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1859#discussion_r93748252 --- Diff: ui/scripts/configuration.js --- @@ -2640,12 +2640,30 @@ }

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread rajesh-battala
Github user rajesh-battala commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1859#discussion_r93747834 --- Diff: server/src/com/cloud/hypervisor/HypervisorGuruBase.java --- @@ -132,7 +133,12 @@ protected VirtualMachineTO

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread rajesh-battala
Github user rajesh-battala commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1859#discussion_r93746500 --- Diff: engine/schema/src/com/cloud/dc/dao/DataCenterIpAddressDaoImpl.java --- @@ -177,6 +177,22 @@ public void releaseIpAddress(long nicId,

[GitHub] cloudstack pull request #1859: CLOUDSTACK - 8672 : NCC Integration with Clou...

2016-12-23 Thread nitin-maharana
GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1859 CLOUDSTACK - 8672 : NCC Integration with CloudStack Feature Specification Link :