Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1953
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102539843
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -584,18 +584,36 @@ public void defFileBasedDisk
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102539356
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm)
Github user HrWiggles commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102342529
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -584,18 +584,36 @@ public void defFileBasedDisk(Stri
Github user HrWiggles commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102336557
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm)
{
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102311697
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
---
@@ -716,11 +734,6 @@ public DiskFmtType getDiskFor
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102309898
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm)
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102303566
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm)
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102303488
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm)
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102303229
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm)
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102302052
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm)
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102301869
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm)
Github user sureshanaparti commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102301645
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm)
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102294407
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102291066
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm
Github user HrWiggles commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102179249
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm)
{
Github user HrWiggles commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102181285
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm)
{
Github user HrWiggles commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102178630
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm)
{
Github user HrWiggles commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102184780
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm)
{
Github user HrWiggles commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102187534
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm)
{
Github user HrWiggles commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1953#discussion_r102177792
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -2639,22 +2639,23 @@ private int getMaxDataVolumesSupported(UserVmVO vm)
{
GitHub user sureshanaparti opened a pull request:
https://github.com/apache/cloudstack/pull/1953
CLOUDSTACK-9794: Unable to attach more than 14 devices to a VM
Updated hardcoded value with max data volumes limit from hypervisor
capabilities.
You can merge this pull request into a G
22 matches
Mail list logo
