Re: [I] v2.15.0 breaking change regarding displayText handling for CreateNetwork [cloudstack-go]

2024-03-15 Thread via GitHub
shwstppr commented on issue #70: URL: https://github.com/apache/cloudstack-go/issues/70#issuecomment-1999201665 Closing this based on recent changes and provision for forcing params to be required in #79 @hrak please reopen if we need further work. -- This is an automated message from

Re: [I] v2.15.0 breaking change regarding displayText handling for CreateNetwork [cloudstack-go]

2024-03-15 Thread via GitHub
shwstppr closed issue #70: v2.15.0 breaking change regarding displayText handling for CreateNetwork URL: https://github.com/apache/cloudstack-go/issues/70 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [I] v2.15.0 breaking change regarding displayText handling for CreateNetwork [cloudstack-go]

2024-02-21 Thread via GitHub
shwstppr commented on issue #70: URL: https://github.com/apache/cloudstack-go/issues/70#issuecomment-1956134999 @weizhouapache @rohityadavcloud I've created #77 to restore breaking changes from ACS 4.19. Do we need to do it for 4.18 as well since this issue relates to that? -- This is an

Re: [I] v2.15.0 breaking change regarding displayText handling for CreateNetwork [cloudstack-go]

2024-02-20 Thread via GitHub
rohityadavcloud commented on issue #70: URL: https://github.com/apache/cloudstack-go/issues/70#issuecomment-1953745775 Agree with @weizhouapache, cc @shwstppr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [I] v2.15.0 breaking change regarding displayText handling for CreateNetwork [cloudstack-go]

2024-02-20 Thread via GitHub
shwstppr commented on issue #70: URL: https://github.com/apache/cloudstack-go/issues/70#issuecomment-1953684551 @weizhouapache okay I'll add those removed methods -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] v2.15.0 breaking change regarding displayText handling for CreateNetwork [cloudstack-go]

2024-02-20 Thread via GitHub
weizhouapache commented on issue #70: URL: https://github.com/apache/cloudstack-go/issues/70#issuecomment-1953673993 @shwstppr to keep backward compatibility, can we manually add the methods which are removed by #76 ? (keep both new and old methods) -- This is an automated mes

Re: [I] v2.15.0 breaking change regarding displayText handling for CreateNetwork [cloudstack-go]

2024-02-09 Thread via GitHub
rohityadavcloud commented on issue #70: URL: https://github.com/apache/cloudstack-go/issues/70#issuecomment-1935574849 Agree @weizhouapache - ideally only the older method should be supported. However, we don't promise backward compatibility with the go-sdk, your proposal makes sense. --

Re: [I] v2.15.0 breaking change regarding displayText handling for CreateNetwork [cloudstack-go]

2024-02-09 Thread via GitHub
weizhouapache commented on issue #70: URL: https://github.com/apache/cloudstack-go/issues/70#issuecomment-1935498554 > Since this is optional in newer versions but not removed, the go-sdk can still call/pass it? @rohityadavcloud as understand, the main problem is, users have to ad

Re: [I] v2.15.0 breaking change regarding displayText handling for CreateNetwork [cloudstack-go]

2024-02-08 Thread via GitHub
rohityadavcloud commented on issue #70: URL: https://github.com/apache/cloudstack-go/issues/70#issuecomment-1935474971 Since this is optional in newer versions but not removed, the go-sdk can still call/pass it? -- This is an automated message from the Apache Git Service. To respond to th

Re: [I] v2.15.0 breaking change regarding displayText handling for CreateNetwork [cloudstack-go]

2024-02-08 Thread via GitHub
shwstppr commented on issue #70: URL: https://github.com/apache/cloudstack-go/issues/70#issuecomment-1935401821 @rohityadavcloud @hrak what should be the way forward here? With each ACS release, there will be some breaking changes so should we try to maintain backward compatibility or shoul