RE: [MERGE] Merge VMSync improvement branch into master

2013-07-03 Thread Alex Huang
-Original Message- From: Musayev, Ilya [mailto:imusa...@webmd.net] Sent: Monday, July 1, 2013 10:16 AM To: dev@cloudstack.apache.org Subject: RE: [MERGE] Merge VMSync improvement branch into master Alex, I completely understand. Please keep us in the loop on the progress. If its

Re: [MERGE] Merge VMSync improvement branch into master

2013-07-03 Thread John Burwell
] Sent: Monday, July 1, 2013 10:20 AM To: dev@cloudstack.apache.org Subject: RE: [MERGE] Merge VMSync improvement branch into master Ilya, Thanks! The current problem on this branch is we're trying to distinguish what's actually broken on master and what's broken by introducing this change

RE: [MERGE] Merge VMSync improvement branch into master

2013-07-01 Thread Musayev, Ilya
it. Thanks ilya -Original Message- From: Alex Huang [mailto:alex.hu...@citrix.com] Sent: Friday, June 28, 2013 9:16 PM To: dev@cloudstack.apache.org Subject: RE: [MERGE] Merge VMSync improvement branch into master Given the current state of BVT, I don't think we can reliably merge

RE: [MERGE] Merge VMSync improvement branch into master

2013-07-01 Thread Alex Huang
- From: Musayev, Ilya [mailto:imusa...@webmd.net] Sent: Monday, July 1, 2013 10:16 AM To: dev@cloudstack.apache.org Subject: RE: [MERGE] Merge VMSync improvement branch into master Alex, I completely understand. Please keep us in the loop on the progress. If its functional to some extent

Re: [MERGE] Merge VMSync improvement branch into master

2013-07-01 Thread Kelven Yang
Message- From: David Nalley [mailto:da...@gnsa.us] Sent: Thursday, June 27, 2013 4:34 PM To: dev@cloudstack.apache.org Subject: Re: [MERGE] Merge VMSync improvement branch into master On Thu, Jun 27, 2013 at 5:51 PM, Hugo Trippaers h...@trippaers.nl wrote: I think Ilya offers is great

RE: [MERGE] Merge VMSync improvement branch into master

2013-06-28 Thread Sudha Ponnaganti
: [MERGE] Merge VMSync improvement branch into master I agree with John that a change like this is very hard to test in an automated fashion. Still i have been looking at the numbers for the code coverage with cobertura. I was a bit disappointed to find that we have not made any progress

RE: [MERGE] Merge VMSync improvement branch into master

2013-06-28 Thread Alex Huang
conscientiously push it in under the current circumstances. --Alex -Original Message- From: Sudha Ponnaganti [mailto:sudha.ponnaga...@citrix.com] Sent: Friday, June 28, 2013 7:11 AM To: dev@cloudstack.apache.org Subject: RE: [MERGE] Merge VMSync improvement branch into master Ideally I

Re: [MERGE] Merge VMSync improvement branch into master

2013-06-27 Thread John Burwell
VirtualMachineManagerImpl.java so you can review that file instead. Thanks. --Alex -Original Message- From: Kelven Yang [mailto:kelven.y...@citrix.com] Sent: Tuesday, June 18, 2013 3:38 PM To: dev@cloudstack.apache.org Subject: Re: [MERGE] Merge VMSync improvement branch into master

RE: [MERGE] Merge VMSync improvement branch into master

2013-06-27 Thread Musayev, Ilya
[mailto:jburw...@basho.com] Sent: Thursday, June 27, 2013 2:33 PM To: dev@cloudstack.apache.org Subject: Re: [MERGE] Merge VMSync improvement branch into master Hugo, I completely agree with this stance, and will add a -1 as well. It has been a significant challenge this cycle to complete

Re: [MERGE] Merge VMSync improvement branch into master

2013-06-27 Thread John Burwell
scenarios as possible on my end. Thanks ilya -Original Message- From: John Burwell [mailto:jburw...@basho.com] Sent: Thursday, June 27, 2013 2:33 PM To: dev@cloudstack.apache.org Subject: Re: [MERGE] Merge VMSync improvement branch into master Hugo, I completely agree

Re: [MERGE] Merge VMSync improvement branch into master

2013-06-27 Thread Hugo Trippaers
] Merge VMSync improvement branch into master Hugo, I completely agree with this stance, and will add a -1 as well. It has been a significant challenge this cycle to complete high quality reviews due to the large patch size and short time turnaround time. Going forward, I am going

RE: [MERGE] Merge VMSync improvement branch into master

2013-06-27 Thread Musayev, Ilya
@cloudstack.apache.org Subject: Re: [MERGE] Merge VMSync improvement branch into master Hugo, I completely agree with this stance, and will add a -1 as well. It has been a significant challenge this cycle to complete high quality reviews due to the large patch size and short time

Re: [MERGE] Merge VMSync improvement branch into master

2013-06-27 Thread Hugo Trippaers
:) -Original Message- From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers Sent: Thursday, June 27, 2013 5:51 PM To: dev@cloudstack.apache.org Subject: Re: [MERGE] Merge VMSync improvement branch into master I think Ilya offers is great, my current stance is also to see how we

Re: [MERGE] Merge VMSync improvement branch into master

2013-06-27 Thread David Nalley
On Thu, Jun 27, 2013 at 5:51 PM, Hugo Trippaers h...@trippaers.nl wrote: I think Ilya offers is great, my current stance is also to see how we can bring this forward. I've had the opportunity to meet with several people at the Citrix office in Santa Clara, i'm actually working from their

RE: [MERGE] Merge VMSync improvement branch into master

2013-06-27 Thread Alex Huang
To: dev@cloudstack.apache.org Subject: Re: [MERGE] Merge VMSync improvement branch into master On Thu, Jun 27, 2013 at 5:51 PM, Hugo Trippaers h...@trippaers.nl wrote: I think Ilya offers is great, my current stance is also to see how we can bring this forward. I've had

RE: [MERGE] Merge VMSync improvement branch into master

2013-06-27 Thread Alex Huang
] On Behalf Of Hugo Trippaers Sent: Thursday, June 27, 2013 4:27 PM To: dev@cloudstack.apache.org Subject: Re: [MERGE] Merge VMSync improvement branch into master Let's get it done :-) I'm at about 15% of the entire commit, reading through it line by line... My notes so far (this is just

RE: [MERGE] Merge VMSync improvement branch into master

2013-06-27 Thread Alex Huang
. It is much appreciated. --Alex -Original Message- From: John Burwell [mailto:jburw...@basho.com] Sent: Thursday, June 27, 2013 11:33 AM To: dev@cloudstack.apache.org Subject: Re: [MERGE] Merge VMSync improvement branch into master Hugo, I completely agree with this stance, and will add

Re: [MERGE] Merge VMSync improvement branch into master

2013-06-27 Thread John Burwell
@David The types of concurrency changes introduced in this patch are extremely difficult to completely test in an automated fashion. Therefore, code review for correctness is critical to ensure quality. To be clear, I am not questioning the value of automated testing. I am just noting that it's

Re: [MERGE] Merge VMSync improvement branch into master

2013-06-27 Thread Hugo Trippaers
I agree with John that a change like this is very hard to test in an automated fashion. Still i have been looking at the numbers for the code coverage with cobertura. I was a bit disappointed to find that we have not made any progress with this merge with regards to unit tests and total code

RE: [MERGE] Merge VMSync improvement branch into master

2013-06-26 Thread Alex Huang
, June 18, 2013 3:38 PM To: dev@cloudstack.apache.org Subject: Re: [MERGE] Merge VMSync improvement branch into master On 6/17/13 7:43 PM, Mice Xia mice_...@tcloudcomputing.com wrote: Kelven, After the refactoring, will CS still restart HA enabled VM when it is power off externally (e.g

Re: [MERGE] Merge VMSync improvement branch into master

2013-06-26 Thread Hugo Trippaers
[mailto:kelven.y...@citrix.com] Sent: Tuesday, June 18, 2013 3:38 PM To: dev@cloudstack.apache.org Subject: Re: [MERGE] Merge VMSync improvement branch into master On 6/17/13 7:43 PM, Mice Xia mice_...@tcloudcomputing.com wrote: Kelven, After the refactoring, will CS still restart HA

Re: [MERGE] Merge VMSync improvement branch into master

2013-06-18 Thread Kelven Yang
() is not called when VM's actual state is stopped while expected state is running. Regards Mice -Original Message- From: Kelven Yang [mailto:kelven.y...@citrix.com] Sent: Tuesday, June 18, 2013 5:21 AM To: dev@cloudstack.apache.org Subject: Re: [MERGE] Merge VMSync improvement branch

Re: [MERGE] Merge VMSync improvement branch into master

2013-06-17 Thread Chip Childers
On Mon, Jun 17, 2013 at 04:59:00PM +, Kelven Yang wrote: I'd like to kick off the official merge process. We will start the merge process after the branch has passed necessary tests Kelven Can you share what testing is being run against the branch?

[MERGE] Merge VMSync improvement branch into master

2013-06-17 Thread Kelven Yang
I'd like to kick off the official merge process. We will start the merge process after the branch has passed necessary tests Kelven On 6/10/13 2:51 PM, Kelven Yang kelven.y...@citrix.com wrote: Hi there, Alex Huang and I are targeting to finish the debugging process on VMsync improvement by

Re: [MERGE] Merge VMSync improvement branch into master

2013-06-17 Thread Kelven Yang
Low level classes were tested in unit tests(MessageBus, Job framework, Job dispatchers etc), interface layer changes are guarded through matching the old semantics, but changes are tested manually, we are planning to get this part of testing through BVT system after we have re-based the latest

Re: [MERGE] Merge VMSync improvement branch into master

2013-06-17 Thread John Burwell
Kelven, Did this patch get pushed to Review Board? If so, what is the URL? Thanks. -John On Jun 17, 2013, at 1:40 PM, Kelven Yang kelven.y...@citrix.com wrote: Low level classes were tested in unit tests(MessageBus, Job framework, Job dispatchers etc), interface layer changes are guarded

Re: [MERGE] Merge VMSync improvement branch into master

2013-06-17 Thread Kelven Yang
Haven't created a patch yet, will do it soon after some last wrap-ups. Kelven On 6/17/13 12:03 PM, John Burwell jburw...@basho.com wrote: Kelven, Did this patch get pushed to Review Board? If so, what is the URL? Thanks. -John On Jun 17, 2013, at 1:40 PM, Kelven Yang kelven.y...@citrix.com

RE: [MERGE] Merge VMSync improvement branch into master

2013-06-17 Thread Mice Xia
expected state is running. Regards Mice -Original Message- From: Kelven Yang [mailto:kelven.y...@citrix.com] Sent: Tuesday, June 18, 2013 5:21 AM To: dev@cloudstack.apache.org Subject: Re: [MERGE] Merge VMSync improvement branch into master Haven't created a patch yet, will do it soon