Re: [MERGE] Merge saml2 branch to master

2014-08-28 Thread Rohit Yadav
Hi all, I’ve merged the saml2 branch, let me know if you face any issues. By default this auth plugin is disabled. Will add a page on it and work on its documentation. For now, you may go to the global settings and search for “saml2”, that’s all the place where you need to configure it and it s

Re: [MERGE] Merge saml2 branch to master

2014-08-28 Thread Rohit Yadav
Hi, I’m going ahead with the merge now. I’ll be around in case we have any issue due to the merge. Regards. On 27-Aug-2014, at 12:23 pm, sebgoa wrote: > > On Aug 27, 2014, at 12:15 PM, Rohit Yadav wrote: > >> >> On 27-Aug-2014, at 1:56 am, Ian Duffy wrote: >> >>> Rohit, >>> >>> Not necessar

Re: [MERGE] Merge saml2 branch to master

2014-08-27 Thread Silvano Nogueira Buback
I'm working in cloudstack 4.3 and there some tokens and migrations in Globo.com internal version that I'm not able to share now. Next week I will clean and publish this integration in external repository. On Wed, Aug 27, 2014 at 7:16 AM, Rohit Yadav wrote: > Hi Silvano, > > Great, thanks for sh

Re: [MERGE] Merge saml2 branch to master

2014-08-27 Thread Rohit Yadav
On 27-Aug-2014, at 12:23 pm, sebgoa wrote: > How about giving it another 24/48 hours …I suspect some folks are still on > vacation hence no many comments. Alright. Regards, Rohit Yadav Software Architect, ShapeBlue M. +41 779015219 | rohit.ya...@shapeblue.com Blog: bhaisaab.org | Twitter: @_bh

Re: [MERGE] Merge saml2 branch to master

2014-08-27 Thread sebgoa
On Aug 27, 2014, at 12:15 PM, Rohit Yadav wrote: > > On 27-Aug-2014, at 1:56 am, Ian Duffy wrote: > >> Rohit, >> >> Not necessary but if your interested in looking into it I'd imagine there's >> an embedded idp maven plugin. >> >> I know for the LDAP stuff we have an embedded Apache DS come

Re: [MERGE] Merge saml2 branch to master

2014-08-27 Thread Rohit Yadav
Hi Silvano, Great, thanks for sharing. Sure, we can change this to suit your plugin as well. I suggest that you fork ACS on github and share your branch/url with us so those of us interested can help you out. Regards. On 27-Aug-2014, at 11:29 am, Silvano Nogueira Buback wrote: > I'm trying

Re: [MERGE] Merge saml2 branch to master

2014-08-27 Thread Rohit Yadav
On 27-Aug-2014, at 1:56 am, Ian Duffy wrote: > Rohit, > > Not necessary but if your interested in looking into it I'd imagine there's > an embedded idp maven plugin. > > I know for the LDAP stuff we have an embedded Apache DS come up with some > bootstrap data. > > Got any documentation? For set

Re: [MERGE] Merge saml2 branch to master

2014-08-27 Thread Silvano Nogueira Buback
I'm trying use your implementation to implement OAuth2. It's almost working, but I think is necessary a little change: Class APIAuthenticationManagerImpl is calling command without correct spring context. I'm working in 4.3 branch, so, I will show what I changed: - org.apache.cloudstack.api.a

Re: [MERGE] Merge saml2 branch to master

2014-08-26 Thread Ian Duffy
Rohit, Not necessary but if your interested in looking into it I'd imagine there's an embedded idp maven plugin. I know for the LDAP stuff we have an embedded Apache DS come up with some bootstrap data. Got any documentation? For setup purposes Other than that +1 Hi Sebastien, On 26-Aug-2014,

Re: [MERGE] Merge saml2 branch to master

2014-08-26 Thread Rohit Yadav
On 26-Aug-2014, at 11:47 am, Sebastien Goasguen wrote: > we do have some selenium tests in /test/selenium but I don't think they are > being run. > > +1 from me (satisfied with your answers) Thanks! Few more classes; Class, %Method, %Line, % GetServiceProviderMetaDataCmd100% (1/ 1)62.5% (5/ 8)

Re: [MERGE] Merge saml2 branch to master

2014-08-26 Thread Sebastien Goasguen
On Aug 26, 2014, at 5:41 AM, Rohit Yadav wrote: > Hi Sebastien, > > On 26-Aug-2014, at 10:38 am, Sebastien Goasguen wrote: >> What's the unit test coverage ? > > Class, %Method, %Line, % > SAMLUtils100% (1/ 1)80% (8/ 10)75% (66/ 88) > SAML2UserAuthenticator100% (1/ 1)100% (4/ 4)84.6% (11/ 13)

Re: [MERGE] Merge saml2 branch to master

2014-08-26 Thread Rohit Yadav
Hi Sebastien, On 26-Aug-2014, at 10:38 am, Sebastien Goasguen wrote: > What's the unit test coverage ? Class, %Method, %Line, % SAMLUtils100% (1/ 1)80% (8/ 10)75% (66/ 88) SAML2UserAuthenticator100% (1/ 1)100% (4/ 4)84.6% (11/ 13) SAML2LoginAPIAuthenticatorCmd100% (1/ 1)45.5% (5/ 11)50.8% (63/ 1

Re: [MERGE] Merge saml2 branch to master

2014-08-26 Thread Sebastien Goasguen
On Aug 25, 2014, at 11:34 AM, Rohit Yadav wrote: > Hi all, > > I would like to merge SAML2 SSO/SLO integration with CloudStack. > > This auth mechanism is implemented as a plugin with special auth cmds that > uses an auth framework > (https://cwiki.apache.org/confluence/display/CLOUDSTACK/Au

[MERGE] Merge saml2 branch to master

2014-08-25 Thread Rohit Yadav
Hi all, I would like to merge SAML2 SSO/SLO integration with CloudStack. This auth mechanism is implemented as a plugin with special auth cmds that uses an auth framework (https://cwiki.apache.org/confluence/display/CLOUDSTACK/Authentication+Refactoring) to get the pluggability. The present im