Re: [PROPOSAL] Add getPathSeparator() to DataStoreTO.java

2014-05-19 Thread Min Chen
The proposal looks ok to me. But it may involve several changes in our code base, some places in our code we even used hard-coded separator instead of using constants. With this change, some global cleanup needs to be done to make sure that it will not bring regressions. Thanks -min On 5/13/14 10

RE: [PROPOSAL] Add getPathSeparator() to DataStoreTO.java

2014-05-18 Thread Damoder Reddy
Any thoughts on below proposal?? Thanks & Regards Damodar/ -Original Message- From: Damoder Reddy [mailto:damoder.re...@citrix.com] Sent: Tuesday, May 13, 2014 10:54 PM To: dev@cloudstack.apache.org Cc: Min Chen; Edison Su Subject: [PROPOSAL] Add getPathSeparator() to DataStoreTO.

[PROPOSAL] Add getPathSeparator() to DataStoreTO.java

2014-05-13 Thread Damoder Reddy
Hi, While working on windowsfication of management server, I found the issues when creating a template from a ROOT disk snapshot. It is not able to create template out of that snapshot due to the snapshot path we are constructing before creating template is using "File.Separator" and on windows

[PROPOSAL] Add getPathSeparator() to DataStoreTO.java

2014-05-13 Thread Damoder Reddy
Hi, While working on windowsfication of management server, I found the issues when creating a template from a ROOT disk snapshot. It is not able to create template out of that snapshot due to the snapshot path we are constructing before creating template is using "File.Separator" and on window