Sorry, I might just get part of your commit yesterday when I looked. Now I
saw them. Thanks for your clarification.
-min
On 8/14/14 10:01 AM, "Rohit Yadav" wrote:
>
>On 14-Aug-2014, at 6:54 pm, Min Chen wrote:
>
>> Hi Rohit,
>>
>> Any reason why you didn't implement response class for login a
On 14-Aug-2014, at 6:54 pm, Min Chen wrote:
> Hi Rohit,
>
> Any reason why you didn't implement response class for login and logout
> like any other API cmd? I think that will be useful as mentioned in your
> FS.
In cloud-api, checkout org.apache.cloudstack.api.response.{LoginCmdResponse,
Logo
Hi Min,
On 14-Aug-2014, at 6:54 pm, Min Chen wrote:
> Hi Rohit,
>
> Any reason why you didn't implement response class for login and logout
> like any other API cmd? I think that will be useful as mentioned in your
> FS.
Checkout LoginResponse and LogoutResponse :) also read the annotation in
Hi Rohit,
Any reason why you didn't implement response class for login and logout
like any other API cmd? I think that will be useful as mentioned in your
FS.
Thanks
-min
On 8/12/14 2:10 AM, "Rohit Yadav" wrote:
>This was done:
>https://cwiki.apache.org/confluence/displ
Hi David,
On 13-Aug-2014, at 5:10 am, David Nalley wrote:
> On Tue, Aug 12, 2014 at 5:35 PM, Rohit Yadav
> wrote:
>> Hi Min,
>>
>> For for master, we don’t have any code freeze currently, I think merge
>> request/reviews are not mandatory and I was confident with the changes so I
>> pushed i
On Wed, Aug 13, 2014 at 5:10 AM, David Nalley wrote:
> Code freeze means that we discuss every commit, and only critical or
> blocker bug fixes make it in.
Which in practice means: RM reviews quickly and cherry-picks/merges it.
--
Daan
On Tue, Aug 12, 2014 at 5:35 PM, Rohit Yadav wrote:
> Hi Min,
>
> For for master, we don’t have any code freeze currently, I think merge
> request/reviews are not mandatory and I was confident with the changes so I
> pushed it on master.
>
This is an incorrect understanding of our community nor
Perhaps a source IP ACL so that only
>> specified
>>> IPs can use a standard auth method but all other access mandates OTP/2FA?
>>> Not sure how AWS works with their MFA feature - anyone?
>> MFA is used for accessing UI console where you manage your keys for API
>>
should
> > break, i.e. refactoring.
> >
> > Cheers.
> >
> > On 12-Aug-2014, at 12:32 pm, Stephen Turner
> > wrote:
> >
> >> Are there any UI changes? Some auth mechanisms might need more than just
> > username and password (RSA token, for e
Hi Min,
For for master, we don’t have any code freeze currently, I think merge
request/reviews are not mandatory and I was confident with the changes so I
pushed it on master.
After Daan’s email I did testing at my end (I’ve bunch of zotac zboxes to do
the local testing, it was already failing
Hi Rohit,
My understanding is that you will do this on your feature branch
"auth-refactor", then merge them after passing at least some CI automation
tests. Today, I saw all these commits already in master:
10 hours agoRohit Yadav DefaultLoginAPIAuthenticatorCmd: return userId
as U
?
>
> Cheers,
>
> Adrian
>
> -Original Message-
> From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com]
> Sent: 12 August 2014 11:41
> To: dev@cloudstack.apache.org
> Subject: Re: [SHOW] Authentication refactoring
>
> From the user end there is no ch
rld nothing should
> break, i.e. refactoring.
>
> Cheers.
>
> On 12-Aug-2014, at 12:32 pm, Stephen Turner
> wrote:
>
>> Are there any UI changes? Some auth mechanisms might need more than just
> username and password (RSA token, for example, or even just "give the
al Message-
From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com]
Sent: 12 August 2014 11:41
To: dev@cloudstack.apache.org
Subject: Re: [SHOW] Authentication refactoring
>From the user end there is no change, not in UI or any change expected in
clients except one:
Since login and logout are now implement
A token, for example, or even just "give the 1st,
> 4th and 5th characters").
>
> --
> Stephen Turner
>
>
> -Original Message-
> From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com]
> Sent: 12 August 2014 04:51
> To: dev
> Subject: [SHOW] Authenticat
12 August 2014 04:51
To: dev
Subject: [SHOW] Authentication refactoring
Hi,
The way we handle login and logout is hardcoded and since there is no
APICommand/BaseCmd implementation the apidoc, apidiscovery and other don't
discover these apis. For supporting SAML as an authentication
On 12-Aug-2014, at 11:32 am, Daan Hoogland wrote:
> looks alright at first glance. did you considder IAM/is it going to
> give conflicts there? I don't suppose so as this work is more of a
> front end thing and IAM should be more based in the background but
> keep it in mind anyway;)
> No reason
looks alright at first glance. did you considder IAM/is it going to
give conflicts there? I don't suppose so as this work is more of a
front end thing and IAM should be more based in the background but
keep it in mind anyway;)
No reason why you shouldn't merge, except feature freeze..
On Tue, Aug
This was done:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Authentication+Refactoring
This is the branch:
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/auth-refactor
Updates:
- Every auth mechanism now implements as a APICommand but these are special
Hi,
The way we handle login and logout is hardcoded and since there is no
APICommand/BaseCmd implementation the apidoc, apidiscovery and other don’t
discover these apis. For supporting SAML as an authentication mechanism, I’ve
refactored the Auth mechanism as a pluggable service that loads with
20 matches
Mail list logo
