Re: Review Request 20611: CLOUDSTACK-6202: add expires to call to method make_request() for async apis

2014-04-23 Thread Chiradeep Vittal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20611/#review41245 --- Ship it! Already fixed. - Chiradeep Vittal On April 23, 2014, 5:

Review Request 20611: CLOUDSTACK-6202: add expires to call to method make_request() for async apis

2014-04-23 Thread Yichi Lu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20611/ --- Review request for cloudstack, Chiradeep Vittal and Rohit Yadav. Repository: cl

Re: Review Request 20390: CLOUDSTACK-6202: Add signatureversion and expiring datetime to cloudmonkey, make it configurable

2014-04-17 Thread Rohit Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20390/#review40655 --- Committed a711367e4968ae1fca68e5293ad5e1622a269a37 - Rohit Yadav

Re: Review Request 20390: CLOUDSTACK-6202: Add signatureversion and expiring datetime to cloudmonkey, make it configurable

2014-04-17 Thread Rohit Yadav
> On April 16, 2014, 7:50 a.m., Rohit Yadav wrote: > > If it's backward compatible and works fine, let's merge. LGTM > > Yichi Lu wrote: > Rohit: > As far as I know this will not break the backward compatibility. For API > calls, the signature version and expiration time is consumed by

Re: Review Request 20390: CLOUDSTACK-6202: Add signatureversion and expiring datetime to cloudmonkey, make it configurable

2014-04-17 Thread Rohit Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20390/#review40653 --- Ship it! Ship It! - Rohit Yadav On April 15, 2014, 10:28 p.m., Y

Re: Review Request 20390: CLOUDSTACK-6202: Add signatureversion and expiring datetime to cloudmonkey, make it configurable

2014-04-16 Thread Yichi Lu
> On April 16, 2014, 2:50 a.m., Rohit Yadav wrote: > > If it's backward compatible and works fine, let's merge. LGTM Rohit: As far as I know this will not break the backward compatibility. For API calls, the signature version and expiration time is consumed by server/src/com/cloud/api/ApiServe

Re: Review Request 20387: CLOUDSTACK-6202: Add signatureversion and expires to server/src/com/cloud/api/dispatch/ParamGenericValidationWorker.java

2014-04-16 Thread Rohit Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20387/#review40517 --- GTM, waiting for Chiradeep's review. Let me know if it's already mer

Re: Review Request 20390: CLOUDSTACK-6202: Add signatureversion and expiring datetime to cloudmonkey, make it configurable

2014-04-16 Thread Rohit Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20390/#review40515 --- If it's backward compatible and works fine, let's merge. LGTM - Roh

Re: Review Request 20390: CLOUDSTACK-6202: Add signatureversion and expiring datetime to cloudmonkey, make it configurable

2014-04-16 Thread Rohit Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20390/#review40514 --- cloudmonkey/config.py

Review Request 20390: CLOUDSTACK-6202: Add signatureversion and expiring datetime to cloudmonkey, make it configurable

2014-04-15 Thread Yichi Lu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20390/ --- Review request for cloudstack, Chiradeep Vittal and Rohit Yadav. Repository: cl

Review Request 20387: CLOUDSTACK-6202: Add signatureversion and expires to server/src/com/cloud/api/dispatch/ParamGenericValidationWorker.java

2014-04-15 Thread Yichi Lu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20387/ --- Review request for cloudstack, Chiradeep Vittal and Rohit Yadav. Repository: cl

Re: CLOUDSTACK-6202

2014-03-28 Thread Chiradeep Vittal
arch 28, 2014 at 12:00 PM To: Chiradeep Vittal mailto:chiradeep.vit...@citrix.com>>, "dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>" mailto:dev@cloudstack.apache.org>>, "bhais...@baagi.org<mailto:bhais...@baagi.org>" mailto:bhais...@baagi.or

CLOUDSTACK-6202

2014-03-28 Thread Yichi Lu
I am currently working on this issue. What should datetime string look like for expires? I am thinking of something like: "-e 2011-10-10T12:00:00+0530", or "--expires=2011-10-10T12:00:00+0530". But this may not be convenient for many people, especially the UTC part (+0530). Another way of doing thi