[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #233: Adding cloudstack-kubernetes-provider docs

2021-07-30 Thread GitBox
blueorangutan commented on pull request #233: URL: https://github.com/apache/cloudstack-documentation/pull/233#issuecomment-889760560 Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/233. (SL-JID 116) -- This is an automated message from the Apache Git Service. To resp

[GitHub] [cloudstack-documentation] davidjumani commented on pull request #233: Adding cloudstack-kubernetes-provider docs

2021-07-30 Thread GitBox
davidjumani commented on pull request #233: URL: https://github.com/apache/cloudstack-documentation/pull/233#issuecomment-889757747 @blueorangutan docbuild -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [cloudstack-documentation] davidjumani opened a new pull request #233: Adding cloudstack-kubernetes-provider docs

2021-07-30 Thread GitBox
davidjumani opened a new pull request #233: URL: https://github.com/apache/cloudstack-documentation/pull/233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [cloudstack-kubernetes-provider] davidjumani opened a new pull request #34: Updating for release

2021-07-29 Thread GitBox
davidjumani opened a new pull request #34: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/34 Updating Readme and examples prior to the release -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PROPOSE] RM for CloudStack Kubernetes Provider v1.0

2021-07-29 Thread Rohit Yadav
ache.org ; dev@cloudstack.apache.org Subject: Re: [PROPOSE] RM for CloudStack Kubernetes Provider v1.0 Thanks for your support. As an RM, I'll need access to the cloudstack / cloudstack-kubernetes-provider dockerhub repo. I'll also need my GPG key added to the KEYS file in the apache repo.

Re: [PROPOSE] RM for CloudStack Kubernetes Provider v1.0

2021-07-29 Thread David Jumani
Thanks for your support. As an RM, I'll need access to the cloudstack / cloudstack-kubernetes-provider dockerhub repo. I'll also need my GPG key added to the KEYS file in the apache repo. Could a PMC help me out with that ? pub rsa4096 2021-07-29 [SC] [expires:

[GitHub] [cloudstack-kubernetes-provider] onitake commented on issue #16: [DISCUSS] Work on next release

2021-07-27 Thread GitBox
onitake commented on issue #16: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-887791213 +1 to release. I'll take a look at it @rhtyd . -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [cloudstack-kubernetes-provider] rhtyd commented on issue #16: [DISCUSS] Work on next release

2021-07-26 Thread GitBox
rhtyd commented on issue #16: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-887231506 @davidjumani I've created/pushed latest build to https://hub.docker.com/r/apache/cloudstack-kubernetes-provider/tags?page=1&ordering=last_updated Wh

[GitHub] [cloudstack-kubernetes-provider] rhtyd commented on issue #16: [DISCUSS] Work on next release

2021-07-26 Thread GitBox
rhtyd commented on issue #16: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-887228952 +1, if @onitake and @joschi36 don't respond, I would say let's do some basic smoke-testing to ensure it is working and cut RC. -- This is an automat

[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on issue #16: [DISCUSS] Work on next release

2021-07-26 Thread GitBox
davidjumani commented on issue #16: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-887220783 Ping @rhtyd @onitake @joschi36 shall I take it as an overwhelmingly yes ? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on issue #16: [DISCUSS] Work on next release

2021-07-18 Thread GitBox
davidjumani commented on issue #16: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-882205915 @onitake @joschi36 @rhtyd Since there are no more issues / PRs for v1.0, Shall we cut a release ? -- This is an automated message from the Apache Git

Re: [PROPOSE] RM for CloudStack Kubernetes Provider v1.0

2021-07-15 Thread Suresh Anaparti
+1 Good luck David! Regards, Suresh On 15/07/21, 12:02 PM, "David Jumani" wrote: Hi, I'd like to put myself forward as the release manager for CloudStack Kubernetes Provider<https://github.com/apache/cloudstack-kubernetes-provider> v1.0. This will be

Re: [PROPOSE] RM for CloudStack Kubernetes Provider v1.0

2021-07-15 Thread Simon Weller
+1 From: David Jumani Sent: Thursday, July 15, 2021 1:31 AM To: users ; dev@cloudstack.apache.org Subject: [PROPOSE] RM for CloudStack Kubernetes Provider v1.0 Hi, I'd like to put myself forward as the release manager for CloudStack Kubernetes Pro

[PROPOSE] RM for CloudStack Kubernetes Provider v1.0

2021-07-14 Thread David Jumani
Hi, I'd like to put myself forward as the release manager for CloudStack Kubernetes Provider<https://github.com/apache/cloudstack-kubernetes-provider> v1.0. This will be the first release of CloudStack Kubernetes Provider which facilitates Kubernetes deployments on Cloudstack

[GitHub] [cloudstack-kubernetes-provider] rhtyd commented on pull request #32: Update Kubernetes version to 1.20.6

2021-07-01 Thread GitBox
rhtyd commented on pull request #32: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/32#issuecomment-872179535 Okay removing from 1.0 milestone -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [cloudstack-kubernetes-provider] joschi36 commented on pull request #32: Update Kubernetes version to 1.20.6

2021-06-29 Thread GitBox
joschi36 commented on pull request #32: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/32#issuecomment-870644101 @rhtyd @davidjumani I also vote to move this out of v1.0, so we finally can get the first release done. Never intended to be in 1.0 -- This is an

[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #32: Update Kubernetes version to 1.20.6

2021-06-22 Thread GitBox
davidjumani commented on pull request #32: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/32#issuecomment-865517226 @rhtyd @joschi36 Can this be merged after 1.0 is released? Since there only exist isos for 1.16. Post release isos for 1.18, 1.20 can be created and

[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #32: Update Kubernetes version to 1.20.6

2021-06-21 Thread GitBox
davidjumani commented on pull request #32: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/32#issuecomment-865517226 @rhtyd @joschi36 Can this be merged after 1.0 is released? Since there only exist isos for 1.16. Post release isos for 1.18, 1.20 can be created and

[GitHub] [cloudstack-kubernetes-provider] rhtyd merged pull request #33: Inclusivity changes - change default git branch to 'main'.

2021-06-18 Thread GitBox
rhtyd merged pull request #33: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] [cloudstack-kubernetes-provider] sureshanaparti opened a new pull request #33: Inclusivity changes - change default git branch to 'main'.

2021-06-18 Thread GitBox
sureshanaparti opened a new pull request #33: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/33 Inclusivity changes - change default git branch to 'main'. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [cloudstack-kubernetes-provider] rhtyd commented on pull request #32: Update Kubernetes version to 1.20.6

2021-06-18 Thread GitBox
rhtyd commented on pull request #32: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/32#issuecomment-864006988 Any update on this - can this be merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [cloudstack-kubernetes-provider] rhtyd commented on issue #15: Maintenance

2021-05-25 Thread GitBox
rhtyd commented on issue #15: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/15#issuecomment-847878913 Closing this, @iamcryptoki pl follow #7 and #16 and wait for v1.0 something soon (in coming weeks/months). -- This is an automated message from the Apache Git

[GitHub] [cloudstack-kubernetes-provider] rhtyd closed issue #15: Maintenance

2021-05-25 Thread GitBox
rhtyd closed issue #15: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [cloudstack-kubernetes-provider] rhtyd closed issue #12: Prebuilt container image not found

2021-05-25 Thread GitBox
rhtyd closed issue #12: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [cloudstack-kubernetes-provider] rhtyd commented on issue #12: Prebuilt container image not found

2021-05-25 Thread GitBox
rhtyd commented on issue #12: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/12#issuecomment-847878366 Closing this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack-kubernetes-provider] rhtyd commented on issue #7: Continuous integration (Dockerhub, etc.) needed

2021-05-25 Thread GitBox
rhtyd commented on issue #7: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/7#issuecomment-847878250 Closing this dockerhub and travis are available. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [cloudstack-kubernetes-provider] rhtyd closed issue #7: Continuous integration (Dockerhub, etc.) needed

2021-05-25 Thread GitBox
rhtyd closed issue #7: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [cloudstack-kubernetes-provider] rhtyd merged pull request #29: Inclusivity changes for CloudStack - rename some offensive words/terms as appropriate, that are meaningful and inclusive.

2021-05-21 Thread GitBox
rhtyd merged pull request #29: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/29 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] [cloudstack-kubernetes-provider] joschi36 commented on pull request #32: Update Kubernetes version to 1.20.6

2021-05-20 Thread GitBox
joschi36 commented on pull request #32: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/32#issuecomment-845096111 > @joschi36 Could you provide the iso you used to deploy a 1.20 env ? @davidjumani Hey I'm not sure what you are referring to, but m

[GitHub] [cloudstack-kubernetes-provider] rhtyd merged pull request #31: Improve readme badges

2021-05-20 Thread GitBox
rhtyd merged pull request #31: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/31 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #32: Update Kubernetes version to 1.20.6

2021-05-20 Thread GitBox
davidjumani commented on pull request #32: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/32#issuecomment-845035765 @joschi36 Could you provide the iso you used to deploy a 1.20 env ? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-kubernetes-provider] joschi36 commented on pull request #32: Update Kubernetes version to 1.20.6

2021-05-20 Thread GitBox
joschi36 commented on pull request #32: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/32#issuecomment-845033580 @onitake @davidjumani Can you review this PR? I already tested the software in K8s 1.20 and it seems working. -- This is an automated message from the

[GitHub] [cloudstack-kubernetes-provider] onitake commented on a change in pull request #29: Inclusivity changes for CloudStack - rename some offensive words/terms as appropriate, that are meaningful

2021-05-19 Thread GitBox
onitake commented on a change in pull request #29: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/29#discussion_r635278142 ## File path: Makefile ## @@ -21,7 +21,7 @@ GIT_COMMIT_SHORT=$(shell git rev-parse --short HEAD) GIT_TAG=$(shell git describe

[GitHub] [cloudstack-kubernetes-provider] onitake commented on a change in pull request #29: Inclusivity changes for CloudStack - rename some offensive words/terms as appropriate, that are meaningful

2021-05-19 Thread GitBox
onitake commented on a change in pull request #29: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/29#discussion_r635275404 ## File path: cloudstack_loadbalancer.go ## @@ -121,8 +121,8 @@ func (cs *CSCloud) EnsureLoadBalancer(ctx context.Context

[GitHub] [cloudstack-kubernetes-provider] schlapzz opened a new pull request #32: Update Kubernetes version to 1.20.6

2021-05-18 Thread GitBox
schlapzz opened a new pull request #32: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/32 Kubernetes Version to 1.20.6 and Golang Version to 1.15 Docker image for testing: docker.io/swisstxt/cloudstack-kubernetes-provider:v1.20.6-ae73327f -- This is an

[GitHub] [cloudstack-kubernetes-provider] joschi36 commented on issue #16: [DISCUSS] Work on next release

2021-05-18 Thread GitBox
joschi36 commented on issue #16: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-843172857 @rhtyd I have tested the release, and it seems working. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [cloudstack-kubernetes-provider] joschi36 commented on issue #14: Implement persistent volume support

2021-05-18 Thread GitBox
joschi36 commented on issue #14: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/14#issuecomment-843170555 There is now CSI driver for CloudStack. Do you think we can close this issue? https://github.com/apalia/cloudstack-csi-driver -- This is an automated message

[GitHub] [cloudstack-kubernetes-provider] onitake commented on issue #16: [DISCUSS] Work on next release

2021-05-18 Thread GitBox
onitake commented on issue #16: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-843063679 @rhtyd Your script pushes the source tarballs to a Subversion repository - is that standard practice in the Apache foundation? I'd thought that nobody

[GitHub] [cloudstack-kubernetes-provider] onitake opened a new pull request #31: Improve readme badges

2021-05-18 Thread GitBox
onitake opened a new pull request #31: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/31 The Docker Hub badge won't work when the images are built elsewhere. I replaced it with a version badge and also improved the other badges a bit. The release badge

[GitHub] [cloudstack-kubernetes-provider] onitake commented on issue #15: Maintenance

2021-05-18 Thread GitBox
onitake commented on issue #15: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/15#issuecomment-843028565 Release management and CI is being addressed in #7 and #16 . We have access to Dockerhub now, and containers will be pushed there. Please stay tuned for

[GitHub] [cloudstack-kubernetes-provider] onitake commented on issue #12: Prebuilt container image not found

2021-05-18 Thread GitBox
onitake commented on issue #12: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/12#issuecomment-843023927 This is being address in #7 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [cloudstack-kubernetes-provider] onitake closed issue #5: Submit request to integrate into Kubernetes documentation

2021-05-18 Thread GitBox
onitake closed issue #5: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [cloudstack-kubernetes-provider] onitake commented on issue #5: Submit request to integrate into Kubernetes documentation

2021-05-18 Thread GitBox
onitake commented on issue #5: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/5#issuecomment-843022973 This was already fixed by https://github.com/kubernetes/website/pull/16129 - we can close this issue now. -- This is an automated message from the Apache Git

[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on issue #16: [DISCUSS] Work on next release

2021-05-11 Thread GitBox
davidjumani commented on issue #16: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-839507920 +1 for co-RM and maintaining with @onitake and @joschi36 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [cloudstack-kubernetes-provider] rhtyd commented on issue #16: [DISCUSS] Work on next release

2021-05-11 Thread GitBox
rhtyd commented on issue #16: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-838383420 As the next steps, I've created a script that will help perform source releases (copied from other ACS repos): https://github.com/apache/cloudstack-kuber

[GitHub] [cloudstack-kubernetes-provider] DaanHoogland commented on a change in pull request #29: Inclusivity changes for CloudStack - rename some offensive words/terms as appropriate, that are meanin

2021-05-11 Thread GitBox
DaanHoogland commented on a change in pull request #29: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/29#discussion_r629899906 ## File path: Makefile ## @@ -21,7 +21,7 @@ GIT_COMMIT_SHORT=$(shell git rev-parse --short HEAD) GIT_TAG=$(shell git describe

[GitHub] [cloudstack-kubernetes-provider] rhtyd commented on issue #16: [DISCUSS] Work on next release

2021-05-10 Thread GitBox
rhtyd commented on issue #16: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-836980447 @onitake @joschi36 since this project is under ASF now, a committer or PMC member has right to publish source tarball and to dockerhub. I'll work with you bo

[GitHub] [cloudstack-kubernetes-provider] joschi36 commented on issue #16: [DISCUSS] Work on next release

2021-05-10 Thread GitBox
joschi36 commented on issue #16: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-836442553 What's the status here now? Can we create the release now? -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on a change in pull request #29: Inclusivity changes for CloudStack - rename some offensive words/terms as appropriate, that are meaning

2021-05-10 Thread GitBox
davidjumani commented on a change in pull request #29: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/29#discussion_r629156668 ## File path: cloudstack_loadbalancer.go ## @@ -121,8 +121,8 @@ func (cs *CSCloud) EnsureLoadBalancer(ctx context.Context

[GitHub] [cloudstack-kubernetes-provider] rhtyd commented on a change in pull request #29: Inclusivity changes for CloudStack - rename some offensive words/terms as appropriate, that are meaningful an

2021-05-04 Thread GitBox
rhtyd commented on a change in pull request #29: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/29#discussion_r625988965 ## File path: cloudstack_loadbalancer.go ## @@ -121,8 +121,8 @@ func (cs *CSCloud) EnsureLoadBalancer(ctx context.Context, clusterName

[GitHub] [cloudstack-kubernetes-provider] rhtyd closed issue #28: There is a vulnerability in kubernetes v1.18.2 ,upgrade recommended

2021-05-04 Thread GitBox
rhtyd closed issue #28: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/28 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [cloudstack-kubernetes-provider] rhtyd merged pull request #30: Updating kubernetes version

2021-05-04 Thread GitBox
rhtyd merged pull request #30: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/30 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] [cloudstack-kubernetes-provider] onitake commented on pull request #30: Updating kubernetes version

2021-05-03 Thread GitBox
onitake commented on pull request #30: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/30#issuecomment-831301385 @joschi36 I think this issue is not tied to the minor version bump, but was introduced with k8s 1.17. I know that you are busy, but could you test the

[GitHub] [cloudstack-kubernetes-provider] joschi36 edited a comment on pull request #30: Updating kubernetes version

2021-05-03 Thread GitBox
joschi36 edited a comment on pull request #30: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/30#issuecomment-831244086 @davidjumani When running in my setup I had to change RBAC rules. Got this error: ```I0503 12:44:20.142166 1 leaderelection.go

[GitHub] [cloudstack-kubernetes-provider] joschi36 edited a comment on pull request #30: Updating kubernetes version

2021-05-03 Thread GitBox
joschi36 edited a comment on pull request #30: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/30#issuecomment-831244086 @davidjumani When running in my setup I had to change RBAC rules. Got this error: ```I0503 12:44:20.142166 1 leaderelection.go

[GitHub] [cloudstack-kubernetes-provider] joschi36 commented on pull request #30: Updating kubernetes version

2021-05-03 Thread GitBox
joschi36 commented on pull request #30: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/30#issuecomment-831244086 @davidjumani When running in my setup I had to change RBAC rules. Got this error: ```I0503 12:44:20.142166 1 leaderelection.go:247

[GitHub] [cloudstack-kubernetes-provider] rhtyd commented on pull request #30: Updating kubernetes version

2021-05-03 Thread GitBox
rhtyd commented on pull request #30: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/30#issuecomment-831148853 Thanks @onitake, we'll wait to hear from @joschi36 on tests -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [cloudstack-kubernetes-provider] onitake commented on pull request #30: Updating kubernetes version

2021-05-03 Thread GitBox
onitake commented on pull request #30: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/30#issuecomment-831148076 Thanks, @davidjumani . LGTM from a formal point of view, but please wait for test results from @joschi36 . -- This is an automated message from the

[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #30: Updating kubernetes version

2021-04-29 Thread GitBox
davidjumani commented on pull request #30: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/30#issuecomment-829803339 @joschi36 I've rebuilt it, can you pull it again and try ? @onitake Reverted the change and will open a separate PR -- This is an automated me

[GitHub] [cloudstack-kubernetes-provider] onitake commented on a change in pull request #30: Updating kubernetes version

2021-04-29 Thread GitBox
onitake commented on a change in pull request #30: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/30#discussion_r623466535 ## File path: .travis.yml ## @@ -4,4 +4,7 @@ go: - 1.13 - master -script: make test +services: + - docker + +script: make docker

[GitHub] [cloudstack-kubernetes-provider] sureshanaparti commented on a change in pull request #29: Inclusivity changes for CloudStack - rename some offensive words/terms as appropriate, that are mean

2021-04-29 Thread GitBox
sureshanaparti commented on a change in pull request #29: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/29#discussion_r623089878 ## File path: README.md ## @@ -145,7 +145,7 @@ The CCM supports the same cloud-config configuration file format used by [the

[GitHub] [cloudstack-kubernetes-provider] joschi36 commented on pull request #30: Updating kubernetes version

2021-04-29 Thread GitBox
joschi36 commented on pull request #30: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/30#issuecomment-829227139 Hey @davidjumani > Can use the image over at davidjumani/cloudstack-kubernetes-provider:k-v1.18.18 Is it possible that it's not build

[GitHub] [cloudstack-kubernetes-provider] onitake commented on issue #2: [OLD] Changing from TCP to TCP Proxy doesn't work

2021-04-29 Thread GitBox
onitake commented on issue #2: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/2#issuecomment-829153469 I'm not sure how we can address this... Maybe we should just put a comment in the readme for now. -- This is an automated message from the Apache Git Se

[GitHub] [cloudstack-kubernetes-provider] onitake commented on a change in pull request #30: Updating kubernetes version

2021-04-29 Thread GitBox
onitake commented on a change in pull request #30: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/30#discussion_r622960584 ## File path: Dockerfile ## @@ -18,7 +18,7 @@ FROM golang:1.13 as builder COPY . /go/src/github.com/apache/cloudstack-kubernetes

[GitHub] [cloudstack-kubernetes-provider] onitake commented on a change in pull request #30: Updating kubernetes version

2021-04-29 Thread GitBox
onitake commented on a change in pull request #30: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/30#discussion_r622960377 ## File path: Makefile ## @@ -34,7 +34,7 @@ CMD_SRC=\ .PHONY: all clean docker -all: cloudstack-ccm +all: clean test cloudstack

[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #30: Updating kubernetes version

2021-04-29 Thread GitBox
davidjumani commented on pull request #30: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/30#issuecomment-828988987 @rhtyd Added docker builds to travis. Unit tests are needed which is tracked in https://github.com/apache/cloudstack-kubernetes-provider/issues/23

[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on a change in pull request #29: Inclusivity changes for CloudStack - rename some offensive words/terms as appropriate, that are meaning

2021-04-28 Thread GitBox
davidjumani commented on a change in pull request #29: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/29#discussion_r622768403 ## File path: .travis.yml ## @@ -2,6 +2,6 @@ language: go go: - 1.13 -- master +- main Review comment: Requires

[GitHub] [cloudstack-kubernetes-provider] rhtyd merged pull request #27: Provider should not be a DaemonSet

2021-04-27 Thread GitBox
rhtyd merged pull request #27: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #30: Updating kubernetes version

2021-04-27 Thread GitBox
davidjumani commented on pull request #30: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/30#issuecomment-828166025 @onitake @joschi36 Can you review ? Can use the image over at `davidjumani/cloudstack-kubernetes-provider:k-v1.18.18` Thanks -- This is an

[GitHub] [cloudstack-kubernetes-provider] davidjumani opened a new pull request #30: Updating kubernetes version

2021-04-27 Thread GitBox
davidjumani opened a new pull request #30: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/30 Fixes https://github.com/apache/cloudstack-kubernetes-provider/issues/28 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on a change in pull request #29: Inclusivity changes for CloudStack - rename some offensive words/terms as appropriate, that are meaning

2021-04-27 Thread GitBox
davidjumani commented on a change in pull request #29: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/29#discussion_r621824001 ## File path: Makefile ## @@ -21,7 +21,7 @@ GIT_COMMIT_SHORT=$(shell git rev-parse --short HEAD) GIT_TAG=$(shell git describe

[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on a change in pull request #29: Inclusivity changes for CloudStack - rename some offensive words/terms as appropriate, that are meaning

2021-04-27 Thread GitBox
davidjumani commented on a change in pull request #29: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/29#discussion_r621822210 ## File path: README.md ## @@ -145,7 +145,7 @@ The CCM supports the same cloud-config configuration file format used by [the cs

[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #27: Provider should not be a DaemonSet

2021-04-27 Thread GitBox
davidjumani commented on pull request #27: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27#issuecomment-828134518 @rhtyd Can you merge ? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #27: Provider should not be a DaemonSet

2021-04-27 Thread GitBox
davidjumani commented on pull request #27: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27#issuecomment-828134379 Right, unrelated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [cloudstack-kubernetes-provider] onitake commented on pull request #27: Provider should not be a DaemonSet

2021-04-27 Thread GitBox
onitake commented on pull request #27: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27#issuecomment-827637589 3+ replicas of the cloud provider seems like total overkill. It doesn't store any state, and it doesn't need to be highly available. It will s

[GitHub] [cloudstack-kubernetes-provider] davidjumani edited a comment on pull request #27: Provider should not be a DaemonSet

2021-04-27 Thread GitBox
davidjumani edited a comment on pull request #27: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27#issuecomment-827556759 @onitake Agreed so not necessarily a deamonset, but in the case of a smaller env, there will be 3 pods on maybe 1 or 2 nodes, since most users

[GitHub] [cloudstack-kubernetes-provider] davidjumani edited a comment on pull request #27: Provider should not be a DaemonSet

2021-04-27 Thread GitBox
davidjumani edited a comment on pull request #27: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27#issuecomment-827556759 @onitake Agreed so not necessarily a deamonset, but in the case of a smaller env, there will be 3 pods on maybe 1 or 2 nodes. I'd prefer to

[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #27: Provider should not be a DaemonSet

2021-04-27 Thread GitBox
davidjumani commented on pull request #27: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27#issuecomment-827556759 @onitake Agreed, but in the case of a smaller env, there will be 3 pods on maybe 1 or 2 nodes. I'd prefer to have the replicas proportional to the

[GitHub] [cloudstack-kubernetes-provider] onitake commented on pull request #27: Provider should not be a DaemonSet

2021-04-26 Thread GitBox
onitake commented on pull request #27: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27#issuecomment-826630266 Not really. The original CCM needed to have an instance on each node, to interact with the host system. This is no longer the case with the cloud

[GitHub] [cloudstack-kubernetes-provider] sureshanaparti opened a new pull request #29: Inclusivity changes for CloudStack - rename some offensive words/terms as appropriate, that are meaningful and i

2021-04-26 Thread GitBox
sureshanaparti opened a new pull request #29: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/29 Inclusivity changes for CloudStack - rename some offensive words/terms as appropriate, that are meaningful and inclusive. - Renamed default git branch name from

[GitHub] [cloudstack-kubernetes-provider] rhtyd commented on issue #28: There is a vulnerability in kubernetes v1.18.2 ,upgrade recommended

2021-04-26 Thread GitBox
rhtyd commented on issue #28: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/28#issuecomment-826572036 cc @onitake @joschi36 @davidjumani -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #27: Provider should not be a DaemonSet

2021-04-26 Thread GitBox
davidjumani commented on pull request #27: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27#issuecomment-826537469 @onitake wouldn't it be better if it was run as a daemonset ? -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #27: Provider should not be a DaemonSet

2021-04-25 Thread GitBox
davidjumani commented on pull request #27: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27#issuecomment-826537469 @onitake wouldn't it be better if it was run as a daemonset ? -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [cloudstack-kubernetes-provider] QiAnXinCodeSafe opened a new issue #28: There is a vulnerability in kubernetes v1.18.2 ,upgrade recommended

2021-04-25 Thread GitBox
QiAnXinCodeSafe opened a new issue #28: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/28 https://github.com/apache/cloudstack-kubernetes-provider/blob/25cb3ecdf8e3555bb34c5454f3965aa8b3a7de7c/go.mod#L14 CVE-2020-8558 CVE-2020-8557 CVE-2020-8565 CVE-2020

[GitHub] [cloudstack-kubernetes-provider] onitake commented on issue #16: [DISCUSS] Work on next release

2021-04-23 Thread GitBox
onitake commented on issue #16: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-825485505 Oh, I just noticed something incorrect in the readme: https://github.com/apache/cloudstack-kubernetes-provider/blame/master/README.md#L23 "DeamonSe

[GitHub] [cloudstack-kubernetes-provider] onitake opened a new pull request #27: Provider should not be a DaemonSet

2021-04-23 Thread GitBox
onitake opened a new pull request #27: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27 I mistakenly wrote in the readme that the provider should be DaemonSet. This is wrong and should be removed. The example deployment.yaml is correct. -- This is an

[GitHub] [cloudstack-kubernetes-provider] onitake edited a comment on issue #16: [DISCUSS] Work on next release

2021-04-23 Thread GitBox
onitake edited a comment on issue #16: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-825478426 +1 for releasing 1.0.0. One nitpick: Maybe change https://github.com/apache/cloudstack-kubernetes-provider/blob/master/deployment.yaml#L146 to

[GitHub] [cloudstack-kubernetes-provider] onitake edited a comment on issue #16: [DISCUSS] Work on next release

2021-04-23 Thread GitBox
onitake edited a comment on issue #16: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-825478426 +1 for releasing 1.0.0. One nitpick: Maybe change https://github.com/apache/cloudstack-kubernetes-provider/blob/master/deployment.yaml#L146 to

[GitHub] [cloudstack-kubernetes-provider] onitake commented on issue #16: [DISCUSS] Work on next release

2021-04-23 Thread GitBox
onitake commented on issue #16: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-825478426 I'm also for releasing 1.0.0. One nitpick: Maybe change https://github.com/apache/cloudstack-kubernetes-provider/blob/master/deployment.yaml#L14

[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on issue #16: [DISCUSS] Work on next release

2021-04-22 Thread GitBox
davidjumani commented on issue #16: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-824762383 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack-kubernetes-provider] joschi36 commented on issue #16: [DISCUSS] Work on next release

2021-04-22 Thread GitBox
joschi36 commented on issue #16: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-824703342 I think we can release 1.0.0 now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [cloudstack-kubernetes-provider] rhtyd commented on issue #16: [DISCUSS] Work on next release

2021-04-22 Thread GitBox
rhtyd commented on issue #16: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-824700524 @joschi36 @onitake @davidjumani - I see all PRs merged now, do we have anything outstanding for 1.0 release? -- This is an automated message from the Apache Git

[GitHub] [cloudstack-kubernetes-provider] rhtyd merged pull request #25: use non-root container

2021-04-22 Thread GitBox
rhtyd merged pull request #25: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] [cloudstack-kubernetes-provider] rhtyd merged pull request #26: Update readme to use cloud-config instead of cloudstack.ini

2021-04-22 Thread GitBox
rhtyd merged pull request #26: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/26 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] [cloudstack-kubernetes-provider] joschi36 commented on pull request #26: Update readme to use cloud-config instead of cloudstack.ini

2021-04-22 Thread GitBox
joschi36 commented on pull request #26: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/26#issuecomment-824665624 @davidjumani I don't have any permissions on this repository. @rhtyd would need to merge -- This is an automated message from the Apache Git Servic

[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #26: Update readme to use cloud-config instead of cloudstack.ini

2021-04-22 Thread GitBox
davidjumani commented on pull request #26: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/26#issuecomment-824663163 @joschi36 Could you review and merge ? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack-kubernetes-provider] davidjumani opened a new pull request #26: Update readme to use cloud-config instead of cloudstack.ini

2021-04-22 Thread GitBox
davidjumani opened a new pull request #26: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/26 Updates the readme to use `cloud-config` as the filename while creating the secret to match the deployment -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack-kubernetes-provider] joschi36 commented on pull request #25: use non-root container

2021-04-22 Thread GitBox
joschi36 commented on pull request #25: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/25#issuecomment-824628638 > @joschi36 Tested and works. Also distorless comes with ca certs so they can be removed from the dockerfile @davidjumani I have just removed the

[GitHub] [cloudstack-kubernetes-provider] rhtyd commented on pull request #25: use non-root container

2021-04-22 Thread GitBox
rhtyd commented on pull request #25: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/25#issuecomment-824622039 @davidjumani @joschi36 is this good to merge now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #25: use non-root container

2021-04-22 Thread GitBox
davidjumani commented on pull request #25: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/25#issuecomment-824608536 @joschi36 Tested and works. Also distorless comes with ca certs so they can be removed from the dockerfile -- This is an automated message from the

<    1   2   3   4   5   >