joschi36 commented on issue #2:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/issues/2#issuecomment-823309748
No, this is still an issue. I've just verified:
` Warning SyncLoadBalancerFailed 9s (x2 over 15s) service-controller
Error syncing load balancer: f
joschi36 commented on pull request #25:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/25#issuecomment-823264027
@davidjumani You are totally right. Forgot distroless :sweat_smile:
I have updated the Dockerfile with `distroless/static:nonroot` and tested it
in
davidjumani commented on pull request #25:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/25#issuecomment-823148788
@joschi36 Can try distroless instead which works fine and makes life easier
https://github.com/GoogleContainerTools/distroless/blob/main/base/README.md
rhtyd merged pull request #24:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/24
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about
rhtyd closed issue #13:
URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
joschi36 commented on pull request #24:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/24#issuecomment-823079510
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
joschi36 commented on pull request #25:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/25#issuecomment-823066822
Hi @davidjumani I just created the container from scratch, but when starting
it fails at creating a self-signed cert. Maybe you have an idea
davidjumani commented on pull request #25:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/25#issuecomment-823039778
@joschi36 Sounds good. That's the way we create scratch images with certs in
our deployments. Let me know if I can help with anything
--
This
joschi36 commented on pull request #25:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/25#issuecomment-823037631
> I'd prefer to use a scratch image if possible. That's the most secure imo
@davidjumani We used alpine as we need ca-certificates. But
davidjumani commented on issue #16:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-822971821
+1 for this release. It'll be good to get an official release out to get
wider feedback and then decide how to proceed
--
This is an automated message
davidjumani commented on pull request #25:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/25#issuecomment-822971361
I'd prefer to use a scratch image if possible. That's the most secure imo
--
This is an automated message from the Apache Git Service.
To
rhtyd commented on issue #16:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-822966802
Hi @joschi36 thanks, we've
https://hub.docker.com/r/apache/cloudstack-kubernetes-provider for releases and
builds, I can help with release effort.
--
This
rhtyd commented on pull request #25:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/25#issuecomment-822966237
@onitake @davidjumani are you lgtm on it?
@joschi36 do you have any test results?
--
This is an automated message from the Apache Git Service.
To respond
rhtyd closed issue #20:
URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
rhtyd merged pull request #22:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about
rhtyd commented on pull request #24:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/24#issuecomment-822965778
@onitake @joschi36 are you lgtm on merging this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
rhtyd commented on issue #7:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/issues/7#issuecomment-822965570
We've the official account here now
https://hub.docker.com/r/apache/cloudstack-kubernetes-provider
But only committers/PMC members have access.
--
This
joschi36 edited a comment on issue #16:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-817843326
Hi @rhtyd
For myself I would like to merge #25 to the release.
Maybe @davidjumani has interest in adding #24 and #22 to the release as well
joschi36 commented on issue #16:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-817843326
Hi @rafaelweingartner
For myself I would like to merge #25 to the release.
Maybe @davidjumani has interest in adding #24 and #22 to the release as
onitake commented on issue #16:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-817821132
Sorry @rhtyd I haven't had much time to look at the the k8s provider lately.
Could you coordinate with @joschi36 instead?
I'll gladly contr
rhtyd commented on issue #16:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-817104923
Ping @onitake (work on next release) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
joschi36 opened a new pull request #25:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/25
I have detected that our container
1. does run as root user
2. can't run as non-root user
Therefore, I updated the deployment to run as user 1000 by default and
davidjumani commented on issue #16:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-799076855
+1 Tested and working on v1.16+
This is an automated message from the Apache Git Service.
To
rhtyd commented on issue #16:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-797440578
Ping @onitake cc @davidjumani @gsirett
This is an automated message from the Apache Git Service
rhtyd commented on issue #16:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-781929043
I checked there no outstanding issues/PR on the v1.0 milestone -
https://github.com/apache/cloudstack-kubernetes-provider/milestone/1
rhtyd merged pull request #21:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/21
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
rhtyd closed issue #19:
URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/19
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
rhtyd commented on pull request #21:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/21#issuecomment-781928633
LGTM
This is an automated message from the Apache Git Service.
To respond to the message
rhtyd commented on issue #16:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-781928501
@onitake re-ping, any plans on helping with a release? What PRs should we
fix? Unfortunately, I don't know how to use/test
davidjumani commented on a change in pull request #24:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/24#discussion_r522819039
##
File path: README.md
##
@@ -79,9 +79,8 @@ This will treat the node as 'uninitialized' and cause the CCM
to appl
davidjumani commented on pull request #24:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/24#issuecomment-719428108
@onitake Looks good ?
This is an automated message from the Apache Git Service.
To
davidjumani opened a new pull request #24:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/24
Fixes #13
This is an automated message from the Apache Git Service.
To respond to the message, please log on
davidjumani commented on pull request #22:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/22#issuecomment-719425005
@rhtyd Could you merge this? Thanks!
This is an automated message from the Apache Git
onitake commented on issue #7:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/issues/7#issuecomment-718076952
@rhtyd Was there a followup on the mailing list? I think it got lost...
We definitely need a registry for storing prebuilt containers before we
release 1.0, or
onitake commented on issue #20:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/issues/20#issuecomment-718074827
@rhtyd Please add this to the 1.0 milestone.
This is an automated message from the Apache Git
onitake commented on issue #13:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/issues/13#issuecomment-718074924
@rhtyd Please add this to the 1.0 milestone.
This is an automated message from the Apache Git
onitake commented on issue #13:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/issues/13#issuecomment-718074365
This KEP was merged into Kubernetes 1.17.
@davidjumani Since we're basing milestone 1.0 on 1.18, we should document
the change.
The new label
onitake edited a comment on pull request #22:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/22#issuecomment-718068080
Sorry @davidjumani , this got lost under other stuff.
The framework update script looks very useful indeed!
It was a lot of hassle to manually
onitake commented on pull request #22:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/22#issuecomment-718068080
Sorry @davidjumani , this got lost under other stuff.
The framework update script looks very useful indeed!
It was a lot of hassle to manually update
davidjumani commented on pull request #22:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/22#issuecomment-714905054
@onitake Could you review the changes ?
This is an automated message from the Apache
rhtyd merged pull request #18:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/18
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
rhtyd closed pull request #21:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/21
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
onitake commented on pull request #18:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/18#issuecomment-711068463
@rhtyd Tests ran through, I think you should merge this now. Thanks!
This is an automated
onitake commented on pull request #18:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/18#issuecomment-711065723
Looks like the infra ticket got approved!
I'll try to do a force push to see if it
davidjumani opened a new issue #23:
URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/23
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
davidjumani commented on pull request #22:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/22#issuecomment-710111511
Tests pass. Good to go @onitake
```
go test -v ./...
=== RUN TestReadConfig
--- PASS: TestReadConfig (0.00s)
=== RUN TestNewCSCloud
rhtyd merged pull request #17:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/17
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
onitake commented on pull request #17:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/17#issuecomment-708404459
Thanks for the go-ahead @davidjumani , but I don't have permission to merge.
@rhtyd Can you merge, p
davidjumani commented on pull request #17:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/17#issuecomment-708190591
@onitake Go ahead and merge this so that I can rebase and submit #22
This is an
davidjumani opened a new pull request #22:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/22
Fixes https://github.com/apache/cloudstack-kubernetes-provider/issues/20
Updated the Kubernetes framework to v1.18 since 1.19 introduces
onitake commented on issue #16:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-703755470
@davidjumani Yes, please go ahead!
This is an automated message from the Apache Git Service.
To
davidjumani commented on issue #16:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-703592062
@onitake I can look into
https://github.com/apache/cloudstack-kubernetes-provider/issues/20 if you're
not already
onitake opened a new pull request #21:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/21
Fixes: #19
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
onitake commented on issue #16:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-702603951
Going through all the issues, there is another thing we might want to
consider, but I'm not sure if it should be done for 1.0:
We're building
onitake opened a new issue #20:
URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/20
We're currently building against a very old Kubernetes framework version:
1.15.2
The project is already at 1.19, with 1.20 in alpha.
Update all frameworks to the latest s
onitake commented on issue #16:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-702596507
@rhtyd I think we are ready to cut a release when CI is set up and the
outstanding issues are fixed (i.e. #19 , #18 , #17 )
The version we're runni
onitake commented on issue #19:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/issues/19#issuecomment-702593380
I'll take care of it.
A few question with respect to [the
policy](https://www.apache.org/legal/src-headers.html):
- Should I add a license head
rhtyd opened a new issue #19:
URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/19
I see many scripts and go files don't have the Apache license header, we
need to fix that. cc @onitake
This
rhtyd commented on pull request #18:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/18#issuecomment-702097821
Thanks @onitake I'll reply on that as well
This is an automated message from the Apach
onitake commented on pull request #18:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/18#issuecomment-702073493
@rhtyd I created the INFRA ticket here:
https://issues.apache.org/jira/projects/INFRA/issues/INFRA-20921
I wasn't sure about all the options, p
onitake opened a new pull request #18:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/18
This PR adds a Travis-CI script, test cases, and applies `go fmt` to satisfy
the formatting check.
It should be merged after Travis is enabled on the Github repository, so we
onitake commented on pull request #8:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/8#issuecomment-698179080
This is an automated message from the Apache Git Service.
To respond to the message, please
rhtyd commented on issue #16:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-698153003
ping @onitake - pl advise whenever it's ready for the next release? Thanks
This is an auto
onitake commented on issue #2:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/issues/2#issuecomment-698397268
@joschi36 can you test if this bug still occurs? I think we fixed it with
all the changes in #9 , but I'm not completely
rhtyd merged pull request #8:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/8
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
rhtyd merged pull request #9:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/9
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
rhtyd closed issue #3:
URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/3
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
rhtyd commented on pull request #8:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/8#issuecomment-698181704
This is an automated message from the Apache Git Service.
To respond to the message, please log
onitake commented on issue #2:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/issues/2#issuecomment-698397268
@joschi36 can you test if this bug still occurs? I think we fixed it with
all the changes in #9 , but I'm not completely
onitake opened a new pull request #17:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/17
As discussed in #8 , these are no longer necessary thanks to the first-class
module support in Go 1.13+.
Matching dependency versions is ensured through go.mod and go.sum
onitake commented on pull request #8:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/8#issuecomment-698220571
I think I can write a quick .travis.yml file to do a gobuild and a gotest.
For a proper integration test, we need some kind of of simulation of the CS
rhtyd commented on pull request #8:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/8#issuecomment-698182811
@onitake you may log a ticket with ASF INFRA
(https://issues.apache.org/jira/projects/INFRA) to enable Travis support
https://travis-ci.org/github/apache
rhtyd commented on pull request #8:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/8#issuecomment-698181704
@onitake we've Travis integration for all apache repos, can we leverage that?
This
onitake commented on pull request #8:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/8#issuecomment-698179080
Thanks, @rhtyd .
It would be good if we have some automated builds/tests anyway. These kinds
of PRs should be easy to test
rhtyd commented on issue #16:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-698153003
ping @onitake - pl advise whenever it's ready for the next release? Thanks
This is an auto
rhtyd closed issue #3:
URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/3
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
rhtyd merged pull request #8:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/8
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
rhtyd merged pull request #9:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/9
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
onitake commented on pull request #9:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/9#issuecomment-697404337
@rhtyd Please go ahead and merge #8 and #9.
This is an automated message from the Apache Git
rhtyd commented on pull request #9:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/9#issuecomment-697340438
Is this ready for merging @onitake @joschi36 ? I can merge after #8
This is an automated
rhtyd merged pull request #6:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/6
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
rhtyd commented on pull request #8:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/8#issuecomment-697339828
I'm okay with the changes, but unable to review or test this. I can merge if
you or any other collaborators can do a single review/lgtm and show any
joschi36 commented on pull request #9:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/9#issuecomment-697263875
Works like a charm.
This is an automated message from the Apache Git Service.
To respond to
onitake commented on pull request #8:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/8#issuecomment-697241611
Hi @rhtyd it's actually not necessary to require Go 1.15.
go.mod should reflect the minimum version required to build the module,
which is 1.13. See
onitake commented on pull request #6:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/6#issuecomment-697231932
@rhtyd I think it's ok to merge this now.
The example should be good enough to get people st
onitake commented on pull request #9:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/9#issuecomment-697230091
@joschi36 Is this working as expected now, or do I need to take another look?
This is an
rhtyd commented on pull request #8:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/8#issuecomment-696793893
@onitake can you advise when this is ready for merging, thnx
This is an automated message from
rhtyd commented on pull request #9:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/9#issuecomment-696793816
@onitake can you advise when this is ready for merging, thnx
This is an automated message from
rhtyd commented on pull request #6:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/6#issuecomment-696793982
@onitake can you advise when this is ready for merging, thnx
This is an automated message from
rhtyd commented on pull request #6:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/6#issuecomment-696793982
@onitake can you advise when this is ready for merging, thnx
This is an automated message from
rhtyd commented on pull request #8:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/8#issuecomment-696793893
@onitake can you advise when this is ready for merging, thnx
This is an automated message from
rhtyd commented on pull request #9:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/9#issuecomment-696793816
@onitake can you advise when this is ready for merging, thnx
This is an automated message from
rhtyd commented on issue #16:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/issues/16#issuecomment-689457837
Ping - @onitake any update on this, how can the community help?
This is an automated message from
rhtyd commented on pull request #6:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/6#issuecomment-689457451
Ping @onitake - any update on this?
This is an automated message from the Apache Git Service
rhtyd commented on pull request #8:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/8#issuecomment-689456993
@onitake can you update this and see if we should consider Go v1.15 now?
This is an automated
rhtyd merged pull request #10:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/10
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
rhtyd merged pull request #11:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/11
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
onitake commented on pull request #9:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/9#issuecomment-677652349
I flipped the logic around.
Firewall rules are now deleted _before_ the new rules are added.
This should resolve the issue
onitake commented on issue #15:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/issues/15#issuecomment-677505424
@iamcryptoki You can also take a look at
https://hub.docker.com/repository/docker/swisstxt/cloudstack-kubernetes-provider
- I'm occasionally pushing develo
onitake edited a comment on pull request #9:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/9#issuecomment-674174681
Ok, so as a first measure, I can make EnsureLoadBalancer fail when it
can't create the firewall rules.
This may leave it in an invalid
301 - 400 of 489 matches
Mail list logo
