Re: ConfigDepot vs the Config enum

2016-11-08 Thread Koushik Das
There is no need for any DB script changes. When the MS starts up, it reads all the config depot exposed by manager beans and update the DB appropriately. -Koushik On 07/11/16, 5:28 PM, "Jeff Hair" wrote: Hi, That's what I thought was the case. Is there any particular process for

Re: ConfigDepot vs the Config enum

2016-11-07 Thread Jeff Hair
Hi, That's what I thought was the case. Is there any particular process for moving configs to the depot besides just moving it out of the enum and into a manager bean somewhere? For example, would the pull request(s) need to have a database migration of some kind? Jeff *Jeff Hair* Technical Lead

Re: ConfigDepot vs the Config enum

2016-11-07 Thread Koushik Das
Config enum is legacy code. For any new configuration parameters ConfigDepot should be used. Some of the parameters got moved from Config enum to the appropriate manager classes (where it is getting used). But there are still lot of them left to be moved. Feel free to submit a PR for moving some

ConfigDepot vs the Config enum

2016-11-07 Thread Jeff Hair
Hi, What's the difference between the Config enum and the ConfigDepot? It seems like the configuration options are somwhat arbitrarily split between the two. ConfigDepot entries get created automatically, while ones in the Config enum don't (and thus require a database migration). ConfigDepot item