Re: Protocol to add scripts to a newer version of ACS

2015-12-23 Thread Rafael Weingärtner
Thanks Remi, I will use it in a PR that I am working on. BTW: I have read a few articles (software engineering baseline management of database objects) and searched for some tool to help us with ACS “schema” scripts to update the database during ACS updates. I am drafting a model that we can use t

Re: Protocol to add scripts to a newer version of ACS

2015-12-21 Thread Remi Bergsma
Hi Rafael, You can now make your change in this file: https://github.com/apache/cloudstack/blob/master/setup/db/db/schema-471to480.sql Regards, Remi On 21/12/15 12:05, "Rafael Weingärtner" wrote: >Thank you guys, >I guess I should wait for Remi's PR. > >On Mon, Dec 21, 2015 at 7:20 AM, Remi

Re: Protocol to add scripts to a newer version of ACS

2015-12-21 Thread Sebastien Goasguen
> On Dec 21, 2015, at 1:24 PM, Remi Bergsma wrote: > > Unfortunately the mirror to Github is broken. Pushed 4.7 branch hours ago but > it doesn’t show up. Can only create PR if it arrives. > > confirmed, the mirror is also delayed for the website. > > > > > On 21/12/15 12:05, "Rafael We

Re: Protocol to add scripts to a newer version of ACS

2015-12-21 Thread Remi Bergsma
Unfortunately the mirror to Github is broken. Pushed 4.7 branch hours ago but it doesn’t show up. Can only create PR if it arrives. On 21/12/15 12:05, "Rafael Weingärtner" wrote: >Thank you guys, >I guess I should wait for Remi's PR. > >On Mon, Dec 21, 2015 at 7:20 AM, Remi Bergsma >wrote

Re: Protocol to add scripts to a newer version of ACS

2015-12-21 Thread Rafael Weingärtner
Thank you guys, I guess I should wait for Remi's PR. On Mon, Dec 21, 2015 at 7:20 AM, Remi Bergsma wrote: > - set new version > - create sql files > - construct upgrade path > > Need to be one PR per branch as otherwise you end up on the new version > without upgrade path. We did it like this la

Re: Protocol to add scripts to a newer version of ACS

2015-12-21 Thread Remi Bergsma
- set new version - create sql files - construct upgrade path Need to be one PR per branch as otherwise you end up on the new version without upgrade path. We did it like this last time as well. Will send a PR per branch. Sent from my iPhone > On 21 Dec 2015, at 09:48, Daan Hoogland wrote:

Re: Protocol to add scripts to a newer version of ACS

2015-12-21 Thread Daan Hoogland
Remi, What do you mean by 'more things'? It sounds like i would like to see more then one PR. On Mon, Dec 21, 2015 at 9:19 AM, Remi Bergsma wrote: > More things need to change at the same time. I will try to send a PR for > all of it today. > > Regards, Remi > > Sent from my iPhone > > > On 21 D

Re: Protocol to add scripts to a newer version of ACS

2015-12-21 Thread Remi Bergsma
More things need to change at the same time. I will try to send a PR for all of it today. Regards, Remi Sent from my iPhone > On 21 Dec 2015, at 07:51, Daan Hoogland wrote: > > H Rafael, just make a PR. the 4.7.0 should serve as a proper example. > > On Sun, Dec 20, 2015 at 10:19 PM, Rafae

Re: Protocol to add scripts to a newer version of ACS

2015-12-20 Thread Daan Hoogland
H Rafael, just make a PR. the 4.7.0 should serve as a proper example. On Sun, Dec 20, 2015 at 10:19 PM, Rafael Weingärtner < rafaelweingart...@gmail.com> wrote: > Hi guys, > > I am working on a PR that will require some data to be added to > “guest_os_hypervisor” table. However, there is no “*to4

Protocol to add scripts to a newer version of ACS

2015-12-20 Thread Rafael Weingärtner
Hi guys, I am working on a PR that will require some data to be added to “guest_os_hypervisor” table. However, there is no “*to480.sql” script yet. How is the protocol to add those inserts that I need into the code base? -- Rafael Weingärtner