RE: [DISCUSS] git commit messages

2013-08-16 Thread Musayev, Ilya
+1, this should be really easy to add and helps tremendously and troubleshooting! -Original Message- From: Koushik Das [mailto:koushik@citrix.com] Sent: Friday, August 16, 2013 1:48 AM To: dev@cloudstack.apache.org Subject: RE: [DISCUSS] git commit messages Agree. The message

RE: [DISCUSS] git commit messages

2013-08-16 Thread Rajesh Battala
+1 -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Tuesday, August 13, 2013 2:12 PM To: dev Subject: [DISCUSS] git commit messages LS, I see a lot of commits with only ticket numbers as commit messages. This is not very descriptive and makes me suspicious

Re: [DISCUSS] git commit messages

2013-08-15 Thread Chiradeep Vittal
Not good. Especially since it is documented https://cwiki.apache.org/confluence/x/4wnVAQ On 8/13/13 1:41 AM, Daan Hoogland daan.hoogl...@gmail.com wrote: LS, I see a lot of commits with only ticket numbers as commit messages. This is not very descriptive and makes me suspicious of what I am

RE: [DISCUSS] git commit messages

2013-08-15 Thread Animesh Chaturvedi
Yes the commit message should have a brief summary of the change -Original Message- From: Chiradeep Vittal [mailto:chiradeep.vit...@citrix.com] Sent: Thursday, August 15, 2013 11:36 AM To: dev@cloudstack.apache.org Subject: Re: [DISCUSS] git commit messages Not good. Especially

Re: [DISCUSS] git commit messages

2013-08-15 Thread Daan Hoogland
Subject: Re: [DISCUSS] git commit messages Not good. Especially since it is documented https://cwiki.apache.org/confluence/x/4wnVAQ On 8/13/13 1:41 AM, Daan Hoogland daan.hoogl...@gmail.com wrote: LS, I see a lot of commits with only ticket numbers as commit messages. This is not very

RE: [DISCUSS] git commit messages

2013-08-15 Thread Alex Huang
+1 --Alex -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Thursday, August 15, 2013 11:58 AM To: dev Subject: Re: [DISCUSS] git commit messages ok, I saw some violation passing by containing only CLOUDSTACK-ticket-number as message. I am

RE: [DISCUSS] git commit messages

2013-08-15 Thread Koushik Das
Agree. The message should indicate the root cause of the problem and the solution. -Koushik -Original Message- From: Alex Huang [mailto:alex.hu...@citrix.com] Sent: Friday, August 16, 2013 2:58 AM To: dev@cloudstack.apache.org Subject: RE: [DISCUSS] git commit messages +1