RE: [DISCUSS] try-with-resouce use

2014-06-06 Thread Alex Huang
In general, as long as it works in the new jvm, I don't see us changing the code. However, if you have the time to do it. The upgrade classes are meant to be immutable as far as data goes. So the idea is we can do upgrades from any version to the current version. Because of that, then all

Re: [DISCUSS] try-with-resouce use

2014-06-06 Thread Daan Hoogland
I don't want to fix resource leaks in master in a way we can not backport. That's my point. And no I am not going to do a lot of it but want to set a policy. On Fri, Jun 6, 2014 at 10:46 PM, Alex Huang alex.hu...@citrix.com wrote: In general, as long as it works in the new jvm, I don't see us

RE: [DISCUSS] try-with-resouce use

2014-06-06 Thread Rajani Karuturi
I think in the branches 4.4 and above we should use try-resource-construct for all the upgrade paths. Otherwise we will continue to see resource leaks due to copy-paste-modified code. ~Rajani Sent from my Windows Phone From: Daan