Re: Review Request 13759: Fix CLOUDSTACK-4466 - DHCP capability breaks in 4.2 for MidoNet

2013-08-23 Thread Dave Cahill
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13759/ --- (Updated Aug. 23, 2013, 11:31 a.m.) Review request for cloudstack and Hugo Trip

Re: Review Request 13759: Fix CLOUDSTACK-4466 - DHCP capability breaks in 4.2 for MidoNet

2013-08-27 Thread Sheng Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13759/#review25630 --- Ship it! Ship It! - Sheng Yang On Aug. 23, 2013, 11:31 a.m., Dav

Re: Review Request 13759: Fix CLOUDSTACK-4466 - DHCP capability breaks in 4.2 for MidoNet

2013-08-27 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13759/#review25629 --- Commit a55c75bbd201e53f0aca3e8f8f9dee08cd132a95 in branch refs/head

Re: Review Request 13759: Fix CLOUDSTACK-4466 - DHCP capability breaks in 4.2 for MidoNet

2013-08-27 Thread Sheng Yang
> On Aug. 27, 2013, 7:08 p.m., Sheng Yang wrote: > > Ship It! I've pushed to 4.2-forwarding. But Dave, could you rebase to master? I cannot apply it clearly on MASTER. Also, it's better to use git-format-patch to generated patch. Thanks! - Sheng ---

RE: Review Request 13759: Fix CLOUDSTACK-4466 - DHCP capability breaks in 4.2 for MidoNet

2013-08-27 Thread Animesh Chaturvedi
t: Re: Review Request 13759: Fix CLOUDSTACK-4466 - DHCP capability > breaks in 4.2 for MidoNet > > > > > On Aug. 27, 2013, 7:08 p.m., Sheng Yang wrote: > > > Ship It! > > I've pushed to 4.2-forwarding. > > But Dave, could you rebase to master? I canno

Re: Review Request 13759: Fix CLOUDSTACK-4466 - DHCP capability breaks in 4.2 for MidoNet

2013-08-27 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13759/#review25634 --- Commit 41d2fb3d1704273042fbd02d85a276b2ec00c737 in branch refs/heads

Re: Review Request 13759: Fix CLOUDSTACK-4466 - DHCP capability breaks in 4.2 for MidoNet

2013-08-27 Thread Dave Cahill
> On Aug. 27, 2013, 7:08 p.m., Sheng Yang wrote: > > Ship It! > > Sheng Yang wrote: > I've pushed to 4.2-forwarding. > > But Dave, could you rebase to master? I cannot apply it clearly on MASTER. > > Also, it's better to use git-format-patch to generated patch. > >

Re: Review Request 13759: Fix CLOUDSTACK-4466 - DHCP capability breaks in 4.2 for MidoNet

2013-08-27 Thread Dave Cahill
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13759/ --- (Updated Aug. 28, 2013, 4:35 a.m.) Review request for cloudstack and Sheng Yang

Re: Review Request 13759: Fix CLOUDSTACK-4466 - DHCP capability breaks in 4.2 for MidoNet

2013-09-03 Thread Dave Cahill
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13759/ --- (Updated Sept. 4, 2013, 5:15 a.m.) Review request for cloudstack and Sheng Yang

Re: Review Request 13759: Fix CLOUDSTACK-4466 - DHCP capability breaks in 4.2 for MidoNet

2013-09-10 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13759/#review26016 --- Commit 28af817fcc835c10e4a21f08e971041325ad206d in branch refs/heads