Re: Review Request 26168: There are new VM State Machine changes introduced which were missed to capture the usage events

2014-10-13 Thread Kishan Kavala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26168/#review56384 --- Ship it! Commit 50185b7c3a1fd26e9a8635c28cee70fda32d3fc5 - Kishan

Re: Review Request 26168: There are new VM State Machine changes introduced which were missed to capture the usage events

2014-10-09 Thread Damodar Reddy Talakanti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26168/ --- (Updated Oct. 9, 2014, 6:26 a.m.) Review request for cloudstack, Kishan Kavala

Re: Review Request 26168: There are new VM State Machine changes introduced which were missed to capture the usage events

2014-10-09 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26168/#review55964 --- - Koushik Das On Oct. 9, 2014, 6:26 a.m., Damodar Reddy Talakanti

RE: Review Request 26168: There are new VM State Machine changes introduced which were missed to capture the usage events

2014-10-09 Thread Koushik Das
Somehow the review comments are not showing? 1. Would it make sense to make the pre/post method signature identical? 2. In StateEntry.addTransition(), do you need E and S as separate parameters? From: Koushik Das [mailto:nore...@reviews.apache.org] On Behalf Of Koushik Das Sent:

Re: Review Request 26168: There are new VM State Machine changes introduced which were missed to capture the usage events

2014-10-08 Thread Damodar Reddy Talakanti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26168/ --- (Updated Oct. 9, 2014, 5:37 a.m.) Review request for cloudstack, Kishan Kavala

Re: Review Request 26168: There are new VM State Machine changes introduced which were missed to capture the usage events

2014-10-08 Thread Damodar Reddy Talakanti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26168/ --- (Updated Oct. 9, 2014, 5:36 a.m.) Review request for cloudstack, Kishan Kavala