RE: VR refactoring, concerns and a way out ?

2015-09-24 Thread Ramanath Katru
My vote is for the approach no.1 - to backout completely. Most of VR functionalities are broken and are in a mess to say the least. It definitely will take some time and effort from several folks to get it to a stable state. Ram Katru -Original Message- From: Raja Pullela [mailto:raja.

Re: VR refactoring, concerns and a way out ?

2015-09-24 Thread Sebastien Goasguen
> On Sep 24, 2015, at 2:00 PM, Ramanath Katru wrote: > > My vote is for the approach no.1 - to backout completely. Most of VR > functionalities are broken and are in a mess to say the least. It definitely > will take some time and effort from several folks to get it to a stable state. > So w

Re: VR refactoring, concerns and a way out ?

2015-09-24 Thread Wilder Rodrigues
Raja, A nice way out would be to have more people knowing about coding and git. I have no idea from where you got this non-sense approach, but I would say it can be compared with the previous git flow the community had: not tests; no PRs; no review. @Ramanath: you, and many others, should have

Re: VR refactoring, concerns and a way out ?

2015-09-24 Thread Remi Bergsma
Are you serious? You consider to revert a PR that was merged over 6 months ago? And expect it to become more stable? The problem, in MHO, is not that we find bugs that we consider blockers. The problem is we are unable to resolve them effectively because master is unstable. There currently isn’

Re: VR refactoring, concerns and a way out ?

2015-09-24 Thread sebgoa
On Sep 24, 2015, at 3:17 PM, Remi Bergsma wrote: > Are you serious? You consider to revert a PR that was merged over 6 months > ago? And expect it to become more stable? > I have not followed all the latest development, but if we are talking about the VR refactoring, indeed it happened sever

Re: VR refactoring, concerns and a way out ?

2015-09-24 Thread Raja Pullela
@wilder, Not sure why you would think it as a nonsense approach? sure, you realize amount of code churn and blockers we are dealing with when 4.6 is ready to go out. Agreed, the refactoring happened several months ago and we could have taken a closer look then- the recent blockers filed have

Re: VR refactoring, concerns and a way out ?

2015-09-24 Thread David Nalley
Everything else aside, do we really think that this could be backed out cleanly? The initial merge should be easy to pull out, but 6 months of follow on work? There's no way that's coming out cleanly. --David On Thu, Sep 24, 2015 at 11:21 AM, Raja Pullela wrote: > @wilder, Not sure why you would

Re: VR refactoring, concerns and a way out ?

2015-09-24 Thread Wilder Rodrigues
Raja, Do you actually know the amount of blockers we have and how many are VR related? Because I have seen emails from Rajani around concerning the blockers and I don’t see many. So, yes, I really do think your approach is non-sense. I mentioned it before, about 1 week ago, but I think you just

Re: VR refactoring, concerns and a way out ?

2015-09-24 Thread Raja Pullela
this is very disrespectful... Sorry to say that you don't understand the complexity and impact of this.. Let's not discuss this over an email and agree to disagree with each other... move on! > On Sep 24, 2015, at 10:20 PM, Wilder Rodrigues > wrote: > > Raja, > > Do you actually know the a

Re: VR refactoring, concerns and a way out ?

2015-09-24 Thread Wilder Rodrigues
Thinking about being disrespectful when one doesn’t read the emails, or does but filters parts of the message, and keeps storming about unclear things. Yes, time to move on. We have to get a cloud running. Cheers, Wilder > On 24 Sep 2015, at 20:29, Raja Pullela wrote: > > this is very disresp

Re: VR refactoring, concerns and a way out ?

2015-09-24 Thread Sebastien Goasguen
Folks, Let’s take a deep breath here, everyone is aiming for a good release. With 4.6 we are trying a new way of creating the release, it may not be the best, but I think we need to stick with the current process and release. We can then have a post-mortem and see what worked and what did not w

RE: VR refactoring, concerns and a way out ?

2015-09-30 Thread Somesh Naidu
ld be happy. Regards, Somesh -Original Message- From: Wilder Rodrigues [mailto:wrodrig...@schubergphilis.com] Sent: Thursday, September 24, 2015 8:48 AM To: dev@cloudstack.apache.org Subject: Re: VR refactoring, concerns and a way out ? Raja, A nice way out would be to have more people kno

Re: VR refactoring, concerns and a way out ?

2015-09-30 Thread Sebastien Goasguen
t your approach and fix the router > (stable as per your opinion) for your users. > > This way everyone would be happy. > > Regards, > Somesh > > > -Original Message- > From: Wilder Rodrigues [mailto:wrodrig...@schubergphilis.com] > Sent: Thursday, Septembe

Re: VR refactoring, concerns and a way out ?

2015-09-30 Thread Abhinandan Prateek
I can understand Citrix concern of some critical scenarios being missed. Citrix supports several customers with sometimes weird setups requiring that extra step in fixing and making the code that works in all those scenarios. The current code has been contributed by community, by people who jus

Re: VR refactoring, concerns and a way out ?

2015-10-01 Thread Remi Bergsma
Hi Abhi, Currently we run BVT tests and whatever doesn’t yet work we create a blocker for. The challenge is to make sure when we fix one thing, we do not unintentionally break something else leading to a new blocker. That’s why we do a lot of testing on the PRs fixing blockers, so we keep thing