Re: Review Request: (CLOUDSTACK-1475) update keystore in SSVM and change download iso/template url after Update SSL Certificate

2013-05-20 Thread Chip Childers
On Fri, May 17, 2013 at 06:24:21AM +, Wei Zhou wrote: > > > > On May 17, 2013, 5:18 a.m., Nitin Mehta wrote: > > > Ship It! > > > > Animesh Chaturvedi wrote: > > Nitin can you commit the patch > > > > Nitin Mehta wrote: > > Some files seem to be removed or atleast the location has c

Re: Review Request: (CLOUDSTACK-1475) update keystore in SSVM and change download iso/template url after Update SSL Certificate

2013-05-16 Thread Wei Zhou
> On May 17, 2013, 5:18 a.m., Nitin Mehta wrote: > > Ship It! > > Animesh Chaturvedi wrote: > Nitin can you commit the patch > > Nitin Mehta wrote: > Some files seem to be removed or atleast the location has changed. Needs > to rebased. Wei - can you please take a look and commit it ?

Re: Review Request: (CLOUDSTACK-1475) update keystore in SSVM and change download iso/template url after Update SSL Certificate

2013-05-16 Thread Nitin Mehta
> On May 17, 2013, 5:18 a.m., Nitin Mehta wrote: > > Ship It! > > Animesh Chaturvedi wrote: > Nitin can you commit the patch Some files seem to be removed or atleast the location has changed. Needs to rebased. Wei - can you please take a look and commit it ? - Nitin ---

Re: Review Request: (CLOUDSTACK-1475) update keystore in SSVM and change download iso/template url after Update SSL Certificate

2013-05-16 Thread Wei Zhou
> On March 15, 2013, 5:56 a.m., Nitin Mehta wrote: > > server/src/com/cloud/configuration/Config.java, line 120 > > > > > > are there any dependencies on this flag in the code ? > > We need to remove this flag durin

Re: Review Request: (CLOUDSTACK-1475) update keystore in SSVM and change download iso/template url after Update SSL Certificate

2013-05-16 Thread Nitin Mehta
> On March 15, 2013, 5:56 a.m., Nitin Mehta wrote: > > server/src/com/cloud/configuration/Config.java, line 120 > > > > > > are there any dependencies on this flag in the code ? > > We need to remove this flag durin

Re: Review Request: (CLOUDSTACK-1475) update keystore in SSVM and change download iso/template url after Update SSL Certificate

2013-05-16 Thread Animesh Chaturvedi
> On May 17, 2013, 5:18 a.m., Nitin Mehta wrote: > > Ship It! Nitin can you commit the patch - Animesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9696/#review20681 --

Re: Review Request: (CLOUDSTACK-1475) update keystore in SSVM and change download iso/template url after Update SSL Certificate

2013-05-16 Thread Nitin Mehta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9696/#review20681 --- Ship it! Ship It! - Nitin Mehta On March 15, 2013, 9:54 a.m., Wei

Re: Review Request: (CLOUDSTACK-1475) update keystore in SSVM and change download iso/template url after Update SSL Certificate

2013-05-16 Thread Jayapal Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9696/#review20678 --- Changes are looking fine. Nithin can you also please review the chang