Review Request: (CLOUDSTACK-528) fix some mistakes in configuration table which cause addSecondaryStorage failed when upgrade from 3.0.* to 4.*

2013-05-13 Thread Wei Zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11088/ --- Review request for cloudstack and Chip Childers. Description --- There are

Re: Review Request: (CLOUDSTACK-528) fix some mistakes in configuration table which cause addSecondaryStorage failed when upgrade from 3.0.* to 4.*

2013-05-13 Thread Chip Childers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11088/#review20489 --- Ship it! In 4.1: commit 5ccdf7dc4ad86145633124b9540aadfbfc423f6f A

Re: Review Request: (CLOUDSTACK-528) fix some mistakes in configuration table which cause addSecondaryStorage failed when upgrade from 3.0.* to 4.*

2013-05-24 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11088/#review20984 --- Commit 3e02a76f001b14ad25e5fdc55efc137457e5e52b in branch refs/heads

Re: Review Request: (CLOUDSTACK-528) fix some mistakes in configuration table which cause addSecondaryStorage failed when upgrade from 3.0.* to 4.*

2013-05-24 Thread Nitin Mehta
Would this not be a problem for folks who are already on 4.0 ? On 13/05/13 9:22 PM, "Chip Childers" wrote: > >--- >This is an automatically generated e-mail. To reply, visit: >https://reviews.apache.org/r/11088/#review20489 >---

Re: Review Request: (CLOUDSTACK-528) fix some mistakes in configuration table which cause addSecondaryStorage failed when upgrade from 3.0.* to 4.*

2013-05-24 Thread Chip Childers
It would indeed, but since we are not going to release a 4.0.3, I fixed it in the 4.1 and master branches. At a minimum, this "fix" doesn't regress anything... so while I'm surprised that we didn't run into this issue as reported, I don't see that it's an issue to correct the syntax moving forwar

Re: Review Request: (CLOUDSTACK-528) fix some mistakes in configuration table which cause addSecondaryStorage failed when upgrade from 3.0.* to 4.*

2013-05-24 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11088/#review21001 --- Commit c559c40c3178873177b9f46c46e6c60b5598f2eb in branch refs/heads

Re: Review Request: (CLOUDSTACK-528) fix some mistakes in configuration table which cause addSecondaryStorage failed when upgrade from 3.0.* to 4.*

2013-05-24 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11088/#review21002 --- Commit 09d2fe6a7ddc208f77edf931ed3d57b0afcc2055 in branch refs/heads

Re: Review Request: (CLOUDSTACK-528) fix some mistakes in configuration table which cause addSecondaryStorage failed when upgrade from 3.0.* to 4.*

2013-05-24 Thread Chip Childers
On Fri, May 24, 2013 at 09:49:12AM +, Nitin Mehta wrote: > Would this not be a problem for folks who are already on 4.0 ? Corrected in 4.1 branch: commit c559c40c3178873177b9f46c46e6c60b5598f2eb Author: Chip Childers Date: Fri May 24 17:06:02 2013 +0100 CLOUDSTACK-528: Adding a correc

Re: Review Request: (CLOUDSTACK-528) fix some mistakes in configuration table which cause addSecondaryStorage failed when upgrade from 3.0.* to 4.*

2013-05-24 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11088/#review21015 --- Commit 09d2fe6a7ddc208f77edf931ed3d57b0afcc2055 in branch refs/head

Re: Review Request: (CLOUDSTACK-528) fix some mistakes in configuration table which cause addSecondaryStorage failed when upgrade from 3.0.* to 4.*

2013-05-25 Thread Nitin Mehta
On 24/05/13 7:19 PM, "Chip Childers" wrote: >It would indeed, but since we are not going to release a 4.0.3, I fixed >it in the 4.1 and master branches. > >At a minimum, this "fix" doesn't regress anything... so while I'm >surprised that we didn't run into this issue as reported, I don't see >

Re: Review Request: (CLOUDSTACK-528) fix some mistakes in configuration table which cause addSecondaryStorage failed when upgrade from 3.0.* to 4.*

2013-05-28 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11088/#review21091 --- Commit a65c36a39138308f95049a815fa99f4da0bbde1a in branch refs/heads