Review Request: Changes for Egress firewall rules feature support in SRX

2013-04-08 Thread Jayapal Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10336/ --- Review request for cloudstack, Abhinandan Prateek, Sheng Yang, and Murali Reddy.

Re: Review Request: Changes for Egress firewall rules feature support in SRX

2013-04-08 Thread Sheng Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10336/#review18804 --- plugins/network-elements/juniper-srx/src/com/cloud/network/resource

Re: Review Request: Changes for Egress firewall rules feature support in SRX

2013-04-08 Thread Jayapal Reddy
> On April 8, 2013, 11:25 p.m., Sheng Yang wrote: > > plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java, > > line 830 > > > > > > What's these trafficType and guestVlan for? D

Re: Review Request: Changes for Egress firewall rules feature support in SRX

2013-04-08 Thread Jayapal Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10336/ --- (Updated April 9, 2013, 6:12 a.m.) Review request for cloudstack, Abhinandan Pr

Re: Review Request: Changes for Egress firewall rules feature support in SRX

2013-04-09 Thread Sheng Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10336/#review18867 --- server/src/com/cloud/upgrade/dao/Upgrade410to420.java

Re: Review Request: Changes for Egress firewall rules feature support in SRX

2013-04-09 Thread Sheng Yang
> On April 8, 2013, 11:25 p.m., Sheng Yang wrote: > > plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java, > > line 830 > > > > > > What's these trafficType and guestVlan for? D

Re: Review Request: Changes for Egress firewall rules feature support in SRX

2013-04-10 Thread Jayapal Reddy
> On April 9, 2013, 6:22 p.m., Sheng Yang wrote: > > server/src/com/cloud/upgrade/dao/Upgrade410to420.java, line 331 > > > > > > This would by default allow all egress traffic right? How can these > > rules applied to

Re: Review Request: Changes for Egress firewall rules feature support in SRX

2013-04-10 Thread Jayapal Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10336/ --- (Updated April 10, 2013, 12:46 p.m.) Review request for cloudstack, Abhinandan

Re: Review Request: Changes for Egress firewall rules feature support in SRX

2013-04-10 Thread Jayapal Reddy
> On April 8, 2013, 11:25 p.m., Sheng Yang wrote: > > plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java, > > line 830 > > > > > > What's these trafficType and guestVlan for? D

Re: Review Request: Changes for Egress firewall rules feature support in SRX

2013-04-10 Thread Sheng Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10336/#review18961 --- Ship it! Ship It! - Sheng Yang On April 10, 2013, 12:46 p.m., Ja

Re: Review Request: Changes for Egress firewall rules feature support in SRX

2013-04-12 Thread Abhinandan Prateek
> On April 10, 2013, 6:01 p.m., Sheng Yang wrote: > > Ship It! The patch fails to apply on master please check and resubmit. - Abhinandan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10336

Re: Review Request: Changes for Egress firewall rules feature support in SRX

2013-04-12 Thread Sheng Yang
> On April 10, 2013, 6:01 p.m., Sheng Yang wrote: > > Ship It! > > Abhinandan Prateek wrote: > The patch fails to apply on master please check and resubmit. I've already applied it to master. Seems my comment didn't get out... - Sheng