Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets

2013-05-14 Thread Prasanna Santhanam
The cool thing about this merge was that Sanjeev put in the tests for this feature much before the feature landed in master. It's a demonstration of how tests can proceed in parallel with feature development provided the FS is clear on use cases and API documentation Great work Sanjeev! I just

Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets

2013-05-14 Thread Nitin Mehta
Good initiative Sanjeev. It would be really cool if we can follow this model as much as possible going fwd for feature development. Not to say that the feature dev shouldn't submit the integration tests :). On 14/05/13 3:58 PM, Prasanna Santhanam t...@apache.org wrote: The cool thing about this

Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets

2013-05-14 Thread Chip Childers
On Tue, May 14, 2013 at 10:42:48AM +, Nitin Mehta wrote: Good initiative Sanjeev. It would be really cool if we can follow this model as much as possible going fwd for feature development. Not to say that the feature dev shouldn't submit the integration tests :). Working together with

RE: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets

2013-05-14 Thread Animesh Chaturvedi
-Original Message- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Tuesday, May 14, 2013 7:00 AM To: dev@cloudstack.apache.org Cc: Sanjeev Neelarapu Subject: Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets On Tue, May 14, 2013 at 10:42

Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets

2013-05-13 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11027/ --- (Updated May 13, 2013, 9:34 a.m.) Review request for cloudstack, Abhinandan

Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets

2013-05-13 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11027/#review20481 --- Ship it! Ship It! - Koushik Das On May 13, 2013, 9:34 a.m.,

Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets

2013-05-10 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11027/ --- (Updated May 10, 2013, 6:54 a.m.) Review request for cloudstack, Abhinandan

Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets

2013-05-10 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11027/#review20416 --- core/src/com/cloud/agent/api/routing/createIpAliasCommand.java

Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets

2013-05-10 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11027/ --- (Updated May 10, 2013, 11:18 a.m.) Review request for cloudstack, Abhinandan

Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets

2013-05-10 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11027/ --- (Updated May 10, 2013, 11:51 a.m.) Review request for cloudstack, Abhinandan

Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets

2013-05-10 Thread bharat kumar
On May 10, 2013, 10:49 a.m., Koushik Das wrote: core/src/com/cloud/network/DnsMasqConfigurator.java, line 47 https://reviews.apache.org/r/11027/diff/2/?file=289890#file289890line47 It is better to move this to a separate file so that any changes to the content doesn't require a

Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets

2013-05-10 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11027/ --- (Updated May 10, 2013, 12:08 p.m.) Review request for cloudstack, Abhinandan

Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets

2013-05-10 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11027/ --- (Updated May 10, 2013, 1:50 p.m.) Review request for cloudstack, Abhinandan

Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets

2013-05-10 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11027/ --- (Updated May 10, 2013, 2:23 p.m.) Review request for cloudstack, Abhinandan

Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets

2013-05-10 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11027/ --- (Updated May 10, 2013, 2:30 p.m.) Review request for cloudstack, Abhinandan

Review Request: Cloudstack-702 Multiple Ip ranges in different subnets

2013-05-09 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11027/ --- Review request for cloudstack, Abhinandan Prateek and Koushik Das. Description

Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets

2013-05-08 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10948/#review20307 --- Commit 53e496517ed51bab2c81084a02f49b0408b19a37 in branch

Review Request: Cloudstack-702 Multiple Ip ranges in different subnets

2013-05-06 Thread bharat kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10948/ --- Review request for cloudstack, Abhinandan Prateek and Koushik Das. Description