Re: Review Request: Fix for CLOUDSTACK-2085 VM weight on xen remain same as before vmscaleup

2013-05-20 Thread Harikrishna Patnala
On May 19, 2013, 1:05 p.m., Prasanna Santhanam wrote: plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java, line 144 https://reviews.apache.org/r/10903/diff/2/?file=288093#file288093line144 The if-else logic should be the other way round here.

Re: Review Request: Fix for CLOUDSTACK-2085 VM weight on xen remain same as before vmscaleup

2013-05-20 Thread ASF Subversion and Git Services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10903/#review20757 --- Commit 8da7ec05f1c7dae0aab827ae0568e120111c6579 in branch

Re: Review Request: Fix for CLOUDSTACK-2085 VM weight on xen remain same as before vmscaleup

2013-05-20 Thread Prasanna Santhanam
On May 19, 2013, 1:05 p.m., Prasanna Santhanam wrote: plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java, line 144 https://reviews.apache.org/r/10903/diff/2/?file=288093#file288093line144 The if-else logic should be the other way round here.

Re: Review Request: Fix for CLOUDSTACK-2085 VM weight on xen remain same as before vmscaleup

2013-05-19 Thread Prasanna Santhanam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10903/#review20743 --- Reopening this for review as the fix is incomplete and partly

Re: Review Request: Fix for CLOUDSTACK-2085 VM weight on xen remain same as before vmscaleup

2013-05-19 Thread Harikrishna Patnala
On May 19, 2013, 1:05 p.m., Prasanna Santhanam wrote: plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java, line 144 https://reviews.apache.org/r/10903/diff/2/?file=288093#file288093line144 The if-else logic should be the other way round here.

Re: Review Request: Fix for CLOUDSTACK-2085 VM weight on xen remain same as before vmscaleup

2013-05-19 Thread Prasanna Santhanam
On May 19, 2013, 1:05 p.m., Prasanna Santhanam wrote: plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java, line 144 https://reviews.apache.org/r/10903/diff/2/?file=288093#file288093line144 The if-else logic should be the other way round here.

Re: Review Request: Fix for CLOUDSTACK-2085 VM weight on xen remain same as before vmscaleup

2013-05-15 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10903/ --- (Updated May 15, 2013, 10:06 a.m.) Review request for cloudstack, Abhinandan

Re: Review Request: Fix for CLOUDSTACK-2085 VM weight on xen remain same as before vmscaleup

2013-05-15 Thread Nitin Mehta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10903/#review20569 --- Ship it! Ship It! - Nitin Mehta On May 15, 2013, 10:06 a.m.,

Re: Review Request: Fix for CLOUDSTACK-2085 VM weight on xen remain same as before vmscaleup

2013-05-06 Thread Abhinandan Prateek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10903/#review20179 --- Ship it! Ship It! - Abhinandan Prateek On May 2, 2013, 11:30

Re: Review Request: Fix for CLOUDSTACK-2085 VM weight on xen remain same as before vmscaleup

2013-05-06 Thread Abhinandan Prateek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10903/#review20180 --- Rename the plugin file to all lowercase and resubmit. -