Review Request: Fixed SRX icmp firewall rule configuration issue

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11224/ --- Review request for cloudstack, Abhinandan Prateek, Sheng Yang, and Murali Reddy.

Re: Review Request: Fixed SRX icmp firewall rule configuration issue

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11224/ --- (Updated May 20, 2013, 5:55 a.m.) Review request for cloudstack, Abhinandan Pra

Re: Review Request: Fixed SRX icmp firewall rule configuration issue

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11224/#review20784 --- plugins/network-elements/juniper-srx/src/com/cloud/network/resource

Re: Review Request: Fixed SRX icmp firewall rule configuration issue

> On May 20, 2013, 7 p.m., Sheng Yang wrote: > > plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java, > > line 845 > > > > > > Why ICMP's getSrcPortRange is null(then need the m

Re: Review Request: Fixed SRX icmp firewall rule configuration issue

> On May 20, 2013, 7 p.m., Sheng Yang wrote: > > plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java, > > line 854 > > > > > > I think it's wrong here. Firewall is only firewall

Re: Review Request: Fixed SRX icmp firewall rule configuration issue

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11224/#review20857 --- I am fine with "Ship it". - Sheng Yang On May 20, 2013, 5:55 a.m.

Re: Review Request: Fixed SRX icmp firewall rule configuration issue

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11224/#review20937 --- Ship it! Ship It! - Abhinandan Prateek On May 20, 2013, 5:55 a.m